Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Submission status is confusing when registration is happening after payment is recieved (option enabled) #3924

Closed
LaurensBurger opened this issue Feb 22, 2024 · 0 comments · Fixed by #3935
Closed

Submission status is confusing when registration is happening after payment is recieved (option enabled) #3924

LaurensBurger opened this issue Feb 22, 2024 · 0 comments · Fixed by #3935
Assignees
@SilviaAmAm
Labels
bug Something isn't working needs-backport Fix must be backported to stable release branch
Milestone
Release 2.5.3

Comments

@LaurensBurger
Copy link
Collaborator

LaurensBurger commented Feb 22, 2024 •
edited by joeribekker

Product versie / Product version

2.5.2

Omschrijf het probleem / Describe the bug

Original title: Submission show "processed" unsuccessful when "Wait for payment to register" is enabled.

Payment was completed

image

submission seems to be stuck in a loop:


[2024-02-22 10:15:56 CET] (Submission 1359): Payment plugin "Ogone legacy" (ogone-legacy) order '106' returned from browser flow and set status 'Voltooid door gebruiker'.

Remove
[2024-02-22 10:15:56 CET] (Submission 1359): PDF generation skipped: a report already exists.

Remove
[2024-02-22 10:15:56 CET] (Submission 1359): Registration payment status update skipped.

Remove
[2024-02-22 10:18:00 CET] (Submission 1359): PDF generation skipped: a report already exists.

Remove
[2024-02-22 10:18:00 CET] (Submission 1359): Registration payment status update skipped.

Remove
[2024-02-22 10:23:00 CET] (Submission 1359): PDF generation skipped: a report already exists.

Remove
[2024-02-22 10:23:00 CET] (Submission 1359): Registration payment status update skipped.

Remove
[2024-02-22 10:26:11 CET] (Submission 1359): Confirmation email task started.

Remove
[2024-02-22 10:26:11 CET] (Submission 1359): Confirmation email sent.

Remove
[2024-02-22 10:28:00 CET] (Submission 1359): PDF generation skipped: a report already exists.

Remove
[2024-02-22 10:28:00 CET] (Submission 1359): Registration payment status update skipped.

Remove
[2024-02-22 10:33:00 CET] (Submission 1359): PDF generation skipped: a report already exists.

Remove
[2024-02-22 10:33:00 CET] (Submission 1359): Registration payment status update skipped.

Remove
[2024-02-22 10:38:00 CET] (Submission 1359): PDF generation skipped: a report already exists.

Remove
[2024-02-22 10:38:00 CET] (Submission 1359): Registration payment status update skipped.

Remove
[2024-02-22 10:43:00 CET] (Submission 1359): PDF generation skipped: a report already exists.

Remove
[2024-02-22 10:43:00 CET] (Submission 1359): Registration payment status update skipped.

Remove
[2024-02-22 10:48:00 CET] (Submission 1359): PDF generation skipped: a report already exists.

Remove
[2024-02-22 10:48:00 CET] (Submission 1359): Registration payment status update skipped.

Remove
[2024-02-22 10:53:00 CET] (Submission 1359): PDF generation skipped: a report already exists.

Remove
[2024-02-22 10:53:00 CET] (Submission 1359): Registration payment status update skipped.

Remove
[2024-02-22 10:58:00 CET] (Submission 1359): PDF generation skipped: a report already exists.

Remove
[2024-02-22 10:58:00 CET] (Submission 1359): Registration payment status update skipped.

Remove
[2024-02-22 11:03:00 CET] (Submission 1359): PDF generation skipped: a report already exists.

Remove
[2024-02-22 11:03:00 CET] (Submission 1359): Registration payment status update skipped.

Remove
[2024-02-22 11:08:00 CET] (Submission 1359): PDF generation skipped: a report already exists.

Remove
[2024-02-22 11:08:00 CET] (Submission 1359): Registration payment status update skipped.

Remove
[2024-02-22 11:13:00 CET] (Submission 1359): PDF generation skipped: a report already exists.

Remove
[2024-02-22 11:13:00 CET] (Submission 1359): Registration payment status update skipped.

Remove
[2024-02-22 11:18:00 CET] (Submission 1359): PDF generation skipped: a report already exists.

Remove
[2024-02-22 11:18:00 CET] (Submission 1359): Registration payment status update skipped.

Remove
[2024-02-22 11:23:00 CET] (Submission 1359): PDF generation skipped: a report already exists.

Remove
[2024-02-22 11:23:00 CET] (Submission 1359): Registration payment status update skipped.

Remove
[2024-02-22 11:28:00 CET] (Submission 1359): PDF generation skipped: a report already exists.

Remove
[2024-02-22 11:28:00 CET] (Submission 1359): Registration payment status update skipped.

Remove
[2024-02-22 11:33:00 CET] (Submission 1359): PDF generation skipped: a report already exists.

Remove
[2024-02-22 11:33:00 CET] (Submission 1359): Registration payment status update skipped.

Remove
[2024-02-22 11:38:00 CET] (Submission 1359): PDF generation skipped: a report already exists.

Remove
[2024-02-22 11:38:00 CET] (Submission 1359): Registration payment status update skipped.

Remove
[2024-02-22 11:43:00 CET] (Submission 1359): PDF generation skipped: a report already exists.

Remove
[2024-02-22 11:43:00 CET] (Submission 1359): Registration payment status update skipped.

Remove
[2024-02-22 11:48:00 CET] (Submission 1359): PDF generation skipped: a report already exists.

Remove
[2024-02-22 11:48:00 CET] (Submission 1359): Registration payment status update skipped.

Remove
[2024-02-22 11:53:00 CET] (Submission 1359): PDF generation skipped: a report already exists.

Remove
[2024-02-22 11:53:00 CET] (Submission 1359): Registration payment status update skipped.

Remove
[2024-02-22 11:58:00 CET] (Submission 1359): PDF generation skipped: a report already exists.

Remove
[2024-02-22 11:58:00 CET] (Submission 1359): Registration payment status update skipped.

Remove
[2024-02-22 12:03:00 CET] (Submission 1359): PDF generation skipped: a report already exists.

Remove
[2024-02-22 12:03:00 CET] (Submission 1359): Registration payment status update skipped.

Remove
[2024-02-22 12:08:00 CET] (Submission 1359): PDF generation skipped: a report already exists.

Remove
[2024-02-22 12:08:00 CET] (Submission 1359): Registration payment status update skipped.

Remove
[2024-02-22 12:13:00 CET] (Submission 1359): PDF generation skipped: a report already exists.

Remove
[2024-02-22 12:13:00 CET] (Submission 1359): Registration payment status update skipped.

Remove
[2024-02-22 12:18:00 CET] (Submission 1359): PDF generation skipped: a report already exists.

Remove
[2024-02-22 12:18:00 CET] (Submission 1359): Registration payment status update skipped.

Remove
[2024-02-22 12:23:00 CET] (Submission 1359): PDF generation skipped: a report already exists.

Remove
[2024-02-22 12:23:00 CET] (Submission 1359): Registration payment status update skipped.

Remove
[2024-02-22 12:28:00 CET] (Submission 1359): PDF generation skipped: a report already exists.

Remove
[2024-02-22 12:28:00 CET] (Submission 1359): Registration payment status update skipped.

Remove
[2024-02-22 12:33:00 CET] (Submission 1359): PDF generation skipped: a report already exists.

Remove
[2024-02-22 12:33:00 CET] (Submission 1359): Registration payment status update skipped.

Remove
[2024-02-22 12:38:00 CET] (Submission 1359): PDF generation skipped: a report already exists.

Remove
[2024-02-22 12:38:00 CET] (Submission 1359): Registration payment status update skipped.

Remove
[2024-02-22 12:43:00 CET] (Submission 1359): PDF generation skipped: a report already exists.

Remove
[2024-02-22 12:43:00 CET] (Submission 1359): Registration payment status update skipped.

Remove
[2024-02-22 12:48:00 CET] (Submission 1359): PDF generation skipped: a report already exists.

Remove
[2024-02-22 12:48:00 CET] (Submission 1359): Registration payment status update skipped.

Remove
[2024-02-22 12:53:00 CET] (Submission 1359): PDF generation skipped: a report already exists.

Remove
[2024-02-22 12:53:00 CET] (Submission 1359): Registration payment status update skipped.

Remove
[2024-02-22 12:58:00 CET] (Submission 1359): PDF generation skipped: a report already exists.

Remove
[2024-02-22 12:58:00 CET] (Submission 1359): Registration payment status update skipped.

Remove
[2024-02-22 13:03:00 CET] (Submission 1359): PDF generation skipped: a report already exists.

Remove
[2024-02-22 13:03:00 CET] (Submission 1359): Registration payment status update skipped.

Remove
[2024-02-22 13:08:00 CET] (Submission 1359): PDF generation skipped: a report already exists.

Remove
[2024-02-22 13:08:00 CET] (Submission 1359): Registration payment status update skipped.

Remove
[2024-02-22 13:13:00 CET] (Submission 1359): PDF generation skipped: a report already exists.

Remove
[2024-02-22 13:13:00 CET] (Submission 1359): Registration payment status update skipped.

Remove
[2024-02-22 13:18:00 CET] (Submission 1359): PDF generation skipped: a report already exists.

Remove
[2024-02-22 13:18:00 CET] (Submission 1359): Registration payment status update skipped.

Remove
[2024-02-22 13:23:00 CET] (Submission 1359): PDF generation skipped: a report already exists.

Remove
[2024-02-22 13:23:00 CET] (Submission 1359): Registration payment status update skipped.

Remove
[2024-02-22 13:28:00 CET] (Submission 1359): PDF generation skipped: a report already exists.

Remove
[2024-02-22 13:28:00 CET] (Submission 1359): Registration payment status update skipped.

Remove
[2024-02-22 13:33:00 CET] (Submission 1359): PDF generation skipped: a report already exists.

Remove
[2024-02-22 13:33:00 CET] (Submission 1359): Registration payment status update skipped.

Remove
[2024-02-22 13:38:00 CET] (Submission 1359): PDF generation skipped: a report already exists.

Remove
[2024-02-22 13:38:00 CET] (Submission 1359): Registration payment status update skipped.

Remove
[2024-02-22 13:43:00 CET] (Submission 1359): PDF generation skipped: a report already exists.

Remove
[2024-02-22 13:43:00 CET] (Submission 1359): Registration payment status update skipped.

Remove
[2024-02-22 13:48:00 CET] (Submission 1359): PDF generation skipped: a report already exists.

Remove
[2024-02-22 13:48:00 CET] (Submission 1359): Registration payment status update skipped.

Remove
[2024-02-22 13:53:00 CET] (Submission 1359): PDF generation skipped: a report already exists.

Remove
[2024-02-22 13:53:00 CET] (Submission 1359): Registration payment status update skipped.

Remove
[2024-02-22 13:58:00 CET] (Submission 1359): PDF generation skipped: a report already exists.

Remove
[2024-02-22 13:58:00 CET] (Submission 1359): Registration payment status update skipped.

Remove
[2024-02-22 14:03:00 CET] (Submission 1359): PDF generation skipped: a report already exists.

Remove
[2024-02-22 14:03:00 CET] (Submission 1359): Registration payment status update skipped.

Remove
[2024-02-22 14:08:00 CET] (Submission 1359): PDF generation skipped: a report already exists.

Remove
[2024-02-22 14:08:00 CET] (Submission 1359): Registration payment status update skipped.

Remove
[2024-02-22 14:13:00 CET] (Submission 1359): PDF generation skipped: a report already exists.

Remove
[2024-02-22 14:13:00 CET] (Submission 1359): Registration payment status update skipped.

Stappen om te reproduceren / Steps to reproduce

No response

Verwacht gedrag / Expected behavior

No response

Screen resolution

None

Device

None

OS

None

Browser

No response
@LaurensBurger LaurensBurger added bug Something isn't working triage Issue needs to be validated. Remove this label if the issue considered valid. labels Feb 22, 2024
@sergei-maertens sergei-maertens added the needs-backport Fix must be backported to stable release branch label Feb 22, 2024
@sergei-maertens sergei-maertens added this to the Release 2.5.3 milestone Feb 22, 2024
@joeribekker joeribekker changed the title Submission show "processed" unsuccessful when "Wait for payment to register" is enabled. Submission status is confusing when registration is happening after payment is recieved (option enabled) Feb 26, 2024
@joeribekker joeribekker removed the triage Issue needs to be validated. Remove this label if the issue considered valid. label Feb 26, 2024
SilviaAmAm added a commit that referenced this issue Feb 26, 2024
@SilviaAmAm
✅ [#3924] Check that retry flag is not set after payment
c0bdb2d
SilviaAmAm added a commit that referenced this issue Feb 26, 2024
@SilviaAmAm
🐛 [#3924] Update payment status also if 'wait_for_payment_to_register…
abc3641 
…=True'

The problem was:
If the registration happens after payment, the status of the payment was never changed from 'completed' to 'registered'. The 'finalise_completion' task filters for payments with 'registered' status to decide whether the retry flag should be turned on. This resulted in the retry flag being True even though the payment has been registered.
@SilviaAmAm SilviaAmAm mentioned this issue Feb 26, 2024
Merged
sergei-maertens added a commit that referenced this issue Feb 27, 2024
@sergei-maertens
Merge pull request #3935 from open-formulieren/fix/3924-confusing-flag
3b18fc3 
[#3924] Don't set retry flag when payment is completed successfully
sergei-maertens pushed a commit that referenced this issue Feb 27, 2024
@SilviaAmAm @sergei-maertens
🐛 [#3924] Update payment status also if 'wait_for_payment_to_register…
f8d406e 
…=True'

The problem was:
If the registration happens after payment, the status of the payment was never changed from 'completed' to 'registered'. The 'finalise_completion' task filters for payments with 'registered' status to decide whether the retry flag should be turned on. This resulted in the retry flag being True even though the payment has been registered.

Backport-of: #3935
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SilviaAmAm SilviaAmAm

Labels
bug Something isn't working needs-backport Fix must be backported to stable release branch
Projects
Development
Archived in project
Milestone
Release 2.5.3
Development

Successfully merging a pull request may close this issue.

[#3924] Don't set retry flag when payment is completed successfully open-formulieren/open-forms
4 participants
@joeribekker @sergei-maertens @SilviaAmAm @LaurensBurger