Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block/discourage the use of dots in component keys? #4009

Closed
LaurensBurger opened this issue Mar 14, 2024 · 4 comments · Fixed by #4110 or open-formulieren/open-forms-sdk#668
Closed

Block/discourage the use of dots in component keys? #4009

LaurensBurger opened this issue Mar 14, 2024 · 4 comments · Fixed by #4110 or open-formulieren/open-forms-sdk#668
Assignees
@Viicos
Labels
bug Something isn't working
Milestone
Release 2.7.0

Comments

@LaurensBurger
Copy link
Collaborator

LaurensBurger commented Mar 14, 2024 •
edited

Thema / Theme

Form designer

Omschrijving / Description

currently a user can create a key that results in unexpected behavior.
example:
image

This key automagically changes the "veldengroep" to a dict/object?
image

In the submission the data is also inconsistent:
image
image
@LaurensBurger LaurensBurger added triage Issue needs to be validated. Remove this label if the issue considered valid. enhancement labels Mar 14, 2024
@sergei-maertens
Copy link
Member

This is formio's behaviour which we can't change, it's going to lead to a whole bunch of other unexpected problems.

The displaying of [object Object] for the fieldset should never happen, that's a bug on our end.

The submission admin/display of submitted data is some old code that can definitely be improved too, so let's just fix those things instead.

@sergei-maertens sergei-maertens mentioned this issue Mar 14, 2024
Closed
@joeribekker
Copy link
Contributor

@sergei-maertens refinement agrees.

@joeribekker joeribekker added bug Something isn't working and removed triage Issue needs to be validated. Remove this label if the issue considered valid. enhancement labels Mar 18, 2024
@joeribekker joeribekker added this to the Release 2.7.0 milestone Mar 18, 2024
@Viicos
Copy link
Contributor

Viicos commented Apr 3, 2024 •
edited

I am not able to reproduce anymore on latest, however the merged data is indeed incorrect.

Edit: To reproduce, nested field in the fieldset needs to have the same key:
create a fieldset with key fieldset
create a textfield inside with key fieldset.textfield

However, editing an existing fieldset to follow this pattern leads to an error in the variables:
image

Viicos added a commit that referenced this issue Apr 3, 2024
@Viicos
[#4009] Remove forward annotations
2f1cdaf
Viicos added a commit that referenced this issue Apr 3, 2024
@Viicos
[#4009] Remove merged data from admin form
17b1462
Viicos added a commit that referenced this issue Apr 3, 2024
@Viicos
[#4009] Remove usage of get_ordered_data_with_component_type
3db3497
@Viicos Viicos mentioned this issue Apr 3, 2024
Merged
Viicos added a commit that referenced this issue Apr 3, 2024
@Viicos
[#4009] Remove get_merged_data
1e15483 
In the future, the `data` property could also
be removed, to enforce people using the state wrapper
instead.
Viicos added a commit that referenced this issue Apr 3, 2024
@Viicos
[#4009] Replace usage of get_merged_data
afebb3b
Viicos added a commit that referenced this issue Apr 3, 2024
@Viicos
[#4009] Remove tests related to merged data
88d411b
Viicos added a commit that referenced this issue Apr 4, 2024
@Viicos
[#4009] Remove tests related to merged data
d6c54da
Viicos added a commit to open-formulieren/open-forms-sdk that referenced this issue Apr 4, 2024
@Viicos
[open-formulieren/open-forms#4009] Fix summary display of fieldset
3853e70
@sergei-maertens sergei-maertens mentioned this issue Apr 4, 2024
Merged
sergei-maertens added a commit to open-formulieren/open-forms-sdk that referenced this issue Apr 4, 2024
@sergei-maertens
Merge pull request #668 from open-formulieren/issue/4009
e6a0880 
[open-formulieren/open-forms#4009] Fix summary display of `fieldset`
@sergei-maertens
Copy link
Member

backend PR is still open

sergei-maertens added a commit that referenced this issue Apr 4, 2024
@sergei-maertens
Merge pull request #4110 from open-formulieren/issue/4009-cleanup
ad25a10 
[#4009] Clean up usage of merged data
Viicos added a commit to open-formulieren/open-forms-sdk that referenced this issue Apr 10, 2024
@Viicos
[open-formulieren/open-forms#4009] Fix duplicate creation of submissions
11b9a84 
A race condition is happening and the `useAsync` hook is being called
three times, and `onFormStart` would be called every time as
`onFormStartCalledRef` wasn't set to `true` by the first called in time
@Viicos Viicos mentioned this issue Apr 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Viicos Viicos

Labels
bug Something isn't working
Projects
Development
Archived in project
Milestone
Release 2.7.0
4 participants
@joeribekker @sergei-maertens @Viicos @LaurensBurger