Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Objects API "contract" feature - improvements #4031

Open
1 of 8 tasks
Viicos opened this issue Mar 20, 2024 · 0 comments · Fixed by #4054
Open
1 of 8 tasks

Objects API "contract" feature - improvements #4031

Viicos opened this issue Mar 20, 2024 · 0 comments · Fixed by #4054
Assignees

Comments

@Viicos
Copy link
Contributor

Viicos commented Mar 20, 2024

Follow up of #3688:

  • Backend validation of the variables mapping (Phase 4). Requires the refactor (see Rethink admin Javascript to save a form #3941) to land first.
  • Display backend validation errors back to the frontend:
    • For specific variables, error should be displayed in the variables tab
    • An error should also be displayed if required targets are not mapped. The issue is we are constrained by the DRF error format (strings), and this probably requires a more complex structure.
  • target-paths/ endpoint: handle connection errors to the OT API. Currently returns 500.
  • Display a message when no target path is available? Currently only displays the ------ empty option, which can be confusing.
  • Handle object types where allowGeometry is false
  • To figure out once we get more feedback: the order in which mappings are applied matters (e.g. you can map an object to path > to, and then a string to path > to > otherpath)
  • Use React select for the target-path dropdown
  • Add a popup when switching from v2 to v1, saying all the configured variable mappings will be deleted: [#4031] Add a confirm popup when switching to v2 options #4054
@Viicos Viicos added triage Issue needs to be validated. Remove this label if the issue considered valid. enhancement labels Mar 20, 2024
@joeribekker joeribekker removed the triage Issue needs to be validated. Remove this label if the issue considered valid. label Mar 25, 2024
@Viicos Viicos self-assigned this Mar 25, 2024
@Viicos Viicos linked a pull request Mar 25, 2024 that will close this issue
sergei-maertens added a commit that referenced this issue Mar 25, 2024
[#4031] Add a confirm popup when switching to v2 options
Viicos added a commit that referenced this issue Apr 3, 2024
Viicos added a commit that referenced this issue Apr 3, 2024
Viicos added a commit that referenced this issue Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants