Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to zgw-consumers 0.32.0 #4057

Closed
4 tasks done
sergei-maertens opened this issue Mar 25, 2024 · 0 comments · Fixed by #4059
Closed
4 tasks done

Update to zgw-consumers 0.32.0 #4057

sergei-maertens opened this issue Mar 25, 2024 · 0 comments · Fixed by #4059
Assignees
@sergei-maertens
Labels
enhancement topic: tech debt
Milestone
Release 2.7.0

Comments

@sergei-maertens
Copy link
Member

sergei-maertens commented Mar 25, 2024 •
edited

  • Update to 0.32.0
  • Remove gemma-zds-client from dependencies
  • Add datamigration to copy global zaaktype default to form-level configuration (similar to objects API config)
  • Remove ListZaaktypenMixin from config field
@sergei-maertens sergei-maertens added this to the Release 2.7.0 milestone Mar 25, 2024
@sergei-maertens sergei-maertens self-assigned this Mar 25, 2024
sergei-maertens added a commit that referenced this issue Mar 25, 2024
@sergei-maertens
✅ [#4057] Add test for desired data migration result
13f605e 
Configuration of the fields (defaults) from zgw api group needs to be
stored on the registration backend options so that it's made
explicit.
sergei-maertens added a commit that referenced this issue Mar 25, 2024
@sergei-maertens
🗃️ [#4057] Implement data migration to copy 'global' defaults
ee47d6c 
From zgw api group instance to form backend configuration, making
the fields explicit.
@sergei-maertens sergei-maertens mentioned this issue Mar 25, 2024
Merged
sergei-maertens added a commit that referenced this issue Mar 25, 2024
@sergei-maertens
🔥 [#4057] Remove 'global' defaults for zaaktype/informatieobjecttype
1ba9556 
Instead, make the fields required on the options serializer, ensuring
they're specified for each registration backend.

The previous commit handles the data migration for the instances
without explicit configuration.
sergei-maertens added a commit that referenced this issue Mar 26, 2024
@sergei-maertens
🔥 [#4057] Remove 'global' defaults for zaaktype/informatieobjecttype
a647e28 
Instead, make the fields required on the options serializer, ensuring
they're specified for each registration backend.

The previous commit handles the data migration for the instances
without explicit configuration.
sergei-maertens added a commit that referenced this issue Mar 26, 2024
@sergei-maertens
💚 [#4057] Update tests after model/validation changes
bc38084
sergei-maertens added a commit that referenced this issue Mar 26, 2024
@sergei-maertens
💚 [#4057] Update tests after model/validation changes
b53be20
sergei-maertens added a commit that referenced this issue Mar 26, 2024
@sergei-maertens
👽 [#4057] Address breaking changes in zgw-consumers
35d232b 
Dropping gemma-zds-client means that we can't use any of its
API anymore.
sergei-maertens added a commit that referenced this issue Mar 26, 2024
@sergei-maertens
👽 [#4057] Address breaking changes in zgw-consumers
381ed39 
Dropping gemma-zds-client means that we can't use any of its
API anymore.
sergei-maertens added a commit that referenced this issue Mar 26, 2024
@sergei-maertens
👽 [#4057] Address breaking changes in zgw-consumers
b27de95 
Dropping gemma-zds-client means that we can't use any of its
API anymore.
sergei-maertens added a commit that referenced this issue Mar 26, 2024
@sergei-maertens
✅ [#4057] Add test for desired data migration result
d12f5a6 
Configuration of the fields (defaults) from zgw api group needs to be
stored on the registration backend options so that it's made
explicit.
sergei-maertens added a commit that referenced this issue Mar 26, 2024
@sergei-maertens
🗃️ [#4057] Implement data migration to copy 'global' defaults
40fb244 
From zgw api group instance to form backend configuration, making
the fields explicit.
sergei-maertens added a commit that referenced this issue Mar 26, 2024
@sergei-maertens
🔥 [#4057] Remove 'global' defaults for zaaktype/informatieobjecttype
fefdde0 
Instead, make the fields required on the options serializer, ensuring
they're specified for each registration backend.

The previous commit handles the data migration for the instances
without explicit configuration.
sergei-maertens added a commit that referenced this issue Mar 26, 2024
@sergei-maertens
💚 [#4057] Update tests after model/validation changes
80ee3b8
sergei-maertens added a commit that referenced this issue Mar 26, 2024
@sergei-maertens
👽 [#4057] Address breaking changes in zgw-consumers
a8a2f2e 
Dropping gemma-zds-client means that we can't use any of its
API anymore.
sergei-maertens added a commit that referenced this issue Mar 26, 2024
@sergei-maertens
⬆️ [#4057] Upgrade to zgw-consumers 0.32.0
11a645a 
Which drops gemma-zds-client as dependency.
sergei-maertens added a commit that referenced this issue Mar 26, 2024
@sergei-maertens
⬆️ [#4057] Bump extension to version without zds_client import
19b6158 
The import was a left-over import that didn't have any effect.
sergei-maertens added a commit that referenced this issue Mar 26, 2024
@sergei-maertens
🍱 [#4057] Add more reference data to Open Zaak fixture
3b19b76 
So that this can be used in VCR tests.
sergei-maertens added a commit that referenced this issue Mar 26, 2024
@sergei-maertens
🚚 [#4057] Split zgw plugin options serializer into separate module
d881c8a
sergei-maertens added a commit that referenced this issue Mar 26, 2024
@sergei-maertens
✅ [#4057] Test zaaktype URL validation
07ac5f3
sergei-maertens added a commit that referenced this issue Mar 26, 2024
@sergei-maertens
✅ [#4057] Test documenttype URL validation
9fc6352
sergei-maertens added a commit that referenced this issue Mar 26, 2024
@sergei-maertens
🦺 [#4057] Validate the provided zaaktype/document type against the Ca…
6ed79a6 
…talogi API
sergei-maertens added a commit that referenced this issue Mar 27, 2024
@sergei-maertens
🦺 [#4057] Do not validate business logic during registration
17ea68d 
Discussed with the team on Slack, extensive input validation
where relations between configuration aspects are verified
for consistency and integrity is required, but only during
configuration of the form.

At registration time itself, only the validations that don't
touch external services are performed, so that:

* tests are simpler to write without having to set up mocks
  or VCR, distracting from the actual tested behaviour
* performance during registration is not affected because
  of additional IO. A validation error on this aspect
  would manifest as a runtime error anyway, which is the
  same outcome as the remote API not accepting the
  configured options.
sergei-maertens added a commit that referenced this issue Mar 28, 2024
@sergei-maertens
🦺 [#4057] Do not validate business logic during registration
0e6e787 
Discussed with the team on Slack, extensive input validation
where relations between configuration aspects are verified
for consistency and integrity is required, but only during
configuration of the form.

At registration time itself, only the validations that don't
touch external services are performed, so that:

* tests are simpler to write without having to set up mocks
  or VCR, distracting from the actual tested behaviour
* performance during registration is not affected because
  of additional IO. A validation error on this aspect
  would manifest as a runtime error anyway, which is the
  same outcome as the remote API not accepting the
  configured options.
sergei-maertens added a commit that referenced this issue Mar 28, 2024
@sergei-maertens
♻️ [#4057] Re-write existing tests as VCR tests
e4affe2 
The updated validation would require adding more mocks to the existing
tests, or instead, we can extend the fixture and use VCR for the Open
Zaak API interaction.
sergei-maertens added a commit that referenced this issue Mar 28, 2024
@sergei-maertens
🔨 [#4057] Update release checklist template
cbe57e9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sergei-maertens sergei-maertens

Labels
enhancement topic: tech debt
Projects
Development
Archived in project
Milestone
Release 2.7.0
Development

Successfully merging a pull request may close this issue.

Drop dependency on gemma-zds-client open-formulieren/open-forms
1 participant
@sergei-maertens