Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default value for radio component cannot be undone #4064

Closed
LaurensBurger opened this issue Mar 27, 2024 · 2 comments · Fixed by open-formulieren/formio-builder#151
Closed

Default value for radio component cannot be undone #4064

LaurensBurger opened this issue Mar 27, 2024 · 2 comments · Fixed by open-formulieren/formio-builder#151
Assignees
@vaszig
Labels
bug Something isn't working owner: utrecht topic: form builder
Milestone
Release 2.7.0

Comments

@LaurensBurger
Copy link
Collaborator

LaurensBurger commented Mar 27, 2024 •
edited by joeribekker
Loading

Product versie / Product version

2.5.x - 2.6.0

Omschrijf het probleem / Describe the bug

Once you set a default value for a radio component in the form builder, this choice cannot be undone. You can select another value.
Kooha-2024-03-27-08-58-48

It is possible to remove the defaultValue from the json.
@LaurensBurger LaurensBurger added bug Something isn't working triage Issue needs to be validated. Remove this label if the issue considered valid. labels Mar 27, 2024
@sergei-maertens
Copy link
Member

-> needs a "clear" icon or something like that. HTML-spec wise, this is correct behaviour (and Formio.js does it wrong)

@joeribekker
Copy link
Contributor

Refinement: there is a workaround: (for Laurens) edit the JSON; (for clients) please dont do that and just remove and re-add the component.

@joeribekker joeribekker removed the triage Issue needs to be validated. Remove this label if the issue considered valid. label Apr 8, 2024
@joeribekker joeribekker added this to the Release 2.7.0 milestone Apr 8, 2024
vaszig added a commit to open-formulieren/formio-builder that referenced this issue Apr 24, 2024
@vaszig
[open-formulieren/open-forms#4064] Added the ability to remove defaul…
5f85aa2 
…t value from radio
@vaszig vaszig mentioned this issue Apr 24, 2024
Merged
vaszig added a commit to open-formulieren/formio-builder that referenced this issue Apr 26, 2024
@vaszig
[open-formulieren/open-forms#4064] PR feedback
32ee412
vaszig added a commit to open-formulieren/formio-builder that referenced this issue Apr 26, 2024
@vaszig
[open-formulieren/open-forms#4064] Sergei's PR feedback
2f6162d
vaszig added a commit to open-formulieren/formio-builder that referenced this issue Apr 26, 2024
@vaszig
[open-formulieren/open-forms#4064] Sergei's PR feedback
30039b9
vaszig added a commit to open-formulieren/formio-builder that referenced this issue Apr 26, 2024
@vaszig
[open-formulieren/open-forms#4064] Added the ability to remove defaul…
15e33c8 
…t value from radio
vaszig added a commit to open-formulieren/formio-builder that referenced this issue Apr 26, 2024
@vaszig
[open-formulieren/open-forms#4064] PR feedback
976e635
vaszig added a commit to open-formulieren/formio-builder that referenced this issue Apr 26, 2024
@vaszig
[open-formulieren/open-forms#4064] Sergei's PR feedback
577522d
sergei-maertens pushed a commit to open-formulieren/formio-builder that referenced this issue Apr 26, 2024
@vaszig @sergei-maertens
[open-formulieren/open-forms#4064] Added the ability to remove defaul…
a1d91be 
…t value from radio
sergei-maertens pushed a commit to open-formulieren/formio-builder that referenced this issue Apr 26, 2024
@vaszig @sergei-maertens
[open-formulieren/open-forms#4064] PR feedback
44ceb90
sergei-maertens pushed a commit to open-formulieren/formio-builder that referenced this issue Apr 26, 2024
@vaszig @sergei-maertens
[open-formulieren/open-forms#4064] Sergei's PR feedback
5cc4621
sergei-maertens added a commit to open-formulieren/formio-builder that referenced this issue Apr 26, 2024
@sergei-maertens
🎨 [open-formulieren/open-forms#4064] Tweak UI of clear button and han…
3857e0a 
…dle edge cases

* Empty string as radio option value is technically valid, and clearing
  the default value is now implemented as removing the field from the
  values entiry instead
* The bootstrap CSS behaves weird when an option has no label, causing
  overlap with the clear option. A fallback label is now rendered that
  hints at this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vaszig vaszig

Labels
bug Something isn't working owner: utrecht topic: form builder
Projects
Development
Archived in project
Milestone
Release 2.7.0
Development

Successfully merging a pull request may close this issue.

[OF#4064] Ability to remove default value from radio open-formulieren/formio-builder
4 participants
@joeribekker @sergei-maertens @vaszig @LaurensBurger