Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hidden fields/components are not ignored/skipped for backend input validation #4065

Closed
sergei-maertens opened this issue Mar 27, 2024 · 0 comments · Fixed by #4066
Closed

Hidden fields/components are not ignored/skipped for backend input validation #4065

sergei-maertens opened this issue Mar 27, 2024 · 0 comments · Fixed by #4066
Assignees
@sergei-maertens
Labels
bug Something isn't working needs-backport Fix must be backported to stable release branch
Milestone
Release 2.6.1

Comments

@sergei-maertens
Copy link
Member

Taiga HLM 107

Example response data from _complete endpoint:

{
    "type": "https://testformulieren.haarlemmermeer.nl/fouten/ValidationError/",
    "code": "invalid",
    "title": "Invalid input.",
    "status": 400,
    "detail": "",
    "instance": "urn:uuid:4967d426-873b-4c14-b5e3-881ca47eac81",
    "invalidParams":
    [
        {
            "name": "steps.0.data.alternatiefAdres",
            "code": "required",
            "reason": "Dit veld is vereist."
        }
    ]
}
@sergei-maertens sergei-maertens added the bug Something isn't working label Mar 27, 2024
@sergei-maertens sergei-maertens added this to the Release 2.6.1 milestone Mar 27, 2024
@sergei-maertens sergei-maertens self-assigned this Mar 27, 2024
@sergei-maertens sergei-maertens added the needs-backport Fix must be backported to stable release branch label Mar 27, 2024
sergei-maertens added a commit that referenced this issue Mar 27, 2024
@sergei-maertens
🧪 [#4065] Add regression test with various cases of hidden components
170f317
sergei-maertens added a commit that referenced this issue Mar 27, 2024
@sergei-maertens
🐛 [#4065] Skip validation in serializer fields when components are no…
964c512 
…t visible

This mimicks the validation logic from Formio itself, which forces
a component to be valid when it's not visible or conditionally
hidden.
@sergei-maertens sergei-maertens mentioned this issue Mar 27, 2024
Merged
sergei-maertens added a commit that referenced this issue Mar 27, 2024
@sergei-maertens
🐛 [#4065] Skip validation in serializer fields when components are no…
8529012 
…t visible

This mimicks the validation logic from Formio itself, which forces
a component to be valid when it's not visible or conditionally
hidden.
sergei-maertens added a commit that referenced this issue Mar 27, 2024
@sergei-maertens
🐛 [#4065] Skip validation in serializer fields when components are no…
3d98575 
…t visible

This mimicks the validation logic from Formio itself, which forces
a component to be valid when it's not visible or conditionally
hidden.

Backport-of: #4066
@sergei-maertens sergei-maertens mentioned this issue Mar 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sergei-maertens sergei-maertens

Labels
bug Something isn't working needs-backport Fix must be backported to stable release branch
Projects
Development
Archived in project
Milestone
Release 2.6.1
Development

Successfully merging a pull request may close this issue.

Fix hidden component validation blocking submission completion open-formulieren/open-forms
1 participant
@sergei-maertens