Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StUF-ZDS form-level options are not applied anymore #4073

Closed
sergei-maertens opened this issue Mar 27, 2024 · 1 comment · Fixed by #4111
Closed

StUF-ZDS form-level options are not applied anymore #4073

sergei-maertens opened this issue Mar 27, 2024 · 1 comment · Fixed by #4111
Assignees
@sergei-maertens
Labels
bug Something isn't working owner: haarlemmermeer
Milestone
Release 2.7.0

Comments

@sergei-maertens
Copy link
Member

StUF-ZDS registration does not apply overrides anymore

Commit that broke it: 07ad16f

Reported by HLMM, Taiga 109

Needs backporting until 2.4.x
@sergei-maertens sergei-maertens added bug Something isn't working needs-backport Fix must be backported to stable release branch triage Issue needs to be validated. Remove this label if the issue considered valid. labels Mar 27, 2024
@joeribekker joeribekker added this to the Release 2.6.2 milestone Mar 28, 2024
@sergei-maertens sergei-maertens removed the needs-backport Fix must be backported to stable release branch label Apr 3, 2024
@sergei-maertens
Copy link
Member Author

sergei-maertens commented Apr 3, 2024 •
edited

I looked into this a bit more to see if I could include the bugfix, but this is irrelevant now:

  • gemeentecode was never used - I looked as far back to 1.0.0 and couldn't find any usage of this context variable in .xml templates
  • the global configuration only defines which service to use, so there are no more defaults to override via form-level options. Only the form level serializer options are used (and we have tests for this)

Closing this as wontfix - I will create a PR to remove the gemeentecode fields though.

edit: it was used in commented out code: 05a9887#diff-ff0a3b09bfe82355e2c07da5b0a79ce946fcff9a714cc6557a096fab46e53d4aR48

@sergei-maertens sergei-maertens closed this as not planned Won't fix, can't repro, duplicate, stale Apr 3, 2024
@sergei-maertens sergei-maertens removed the triage Issue needs to be validated. Remove this label if the issue considered valid. label Apr 3, 2024
sergei-maertens added a commit that referenced this issue Apr 3, 2024
@sergei-maertens
⚰️ [#4073] Remove unused StUF-ZDS 'gemeentecode'
cb2f460 
This has never been used anywhere, not even in Open Forms 1.0
@sergei-maertens sergei-maertens self-assigned this Apr 3, 2024
sergei-maertens added a commit that referenced this issue Apr 4, 2024
@sergei-maertens
⚰️ [#4073] Remove unused StUF-ZDS 'gemeentecode'
2d0ad01 
This has never been used anywhere, not even in Open Forms 1.0
@Viicos Viicos mentioned this issue Apr 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sergei-maertens sergei-maertens

Labels
bug Something isn't working owner: haarlemmermeer
Projects
Development
Archived in project
Milestone
Release 2.7.0
Development

Successfully merging a pull request may close this issue.

Remove unused StUF-ZDS 'gemeentecode' open-formulieren/open-forms
2 participants
@joeribekker @sergei-maertens