Registration PDF does not update to display the payment status correctly

[LaurensBurger]

Product versie / Product version

2.5.4
Vught 68
RID 195

Omschrijf het probleem / Describe the bug

When the environment is set to: wait_for_payment_to_register=True
The PDF included in the registration should refelct the successes of the payment. But at the moment it can only display the "old" status:

since it was generated before the payment status was updated.

It should be regenerated at this point to reflect the right payment status.

---

We're including the user-download PDF here to reflect the same status (so, you download a document that states you paid).

• Add timestamp to PDF when it is generated: [#4080] Add timestamp to PDF report #4139
• Handle the case where registration is done before and after payment.
• The PDF after payment needs to reflect the updated payment status and this updated PDF needs to be sent to the registration backend. Whether the PDF is regenerated always during registration or just after payment, is up to the dev, but I (Joeri) wants that the PDF that the client can download is the same as the one sent to the registration backend (with a preference for the same physical file).

[joeribekker]

Refinement: Maybe we should drop support for payment after creating the registration. But, that would make the "betaalstatus" field useless so technically it seems still relevant.

The issue is how to deal with a new version of the PDF that says payment is complete, for all registration backends.

Joeri will ask if the feature "payment after registration" is still needed.