Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select with multiple: true has wrong default value #4084

Closed
5 tasks done
sergei-maertens opened this issue Apr 2, 2024 · 1 comment · Fixed by open-formulieren/formio-builder#135, #4121 or open-formulieren/formio-builder#138
Closed
5 tasks done

Select with multiple: true has wrong default value #4084

sergei-maertens opened this issue Apr 2, 2024 · 1 comment · Fixed by open-formulieren/formio-builder#135, #4121 or open-formulieren/formio-builder#138
Assignees
@Viicos
Labels
bug Something isn't working topic: form builder
Milestone
Release 2.7.0

Comments

@sergei-maertens
Copy link
Member

sergei-maertens commented Apr 2, 2024 •
edited

Currently the form builder produces a default value of [""] (i.e. a list with one element - the empty string), which should just be an empty list entirely ([]) instead.

This causes validation issues, because the empty string is typically not a valid choice.

Tasks

  • Patch form builder
  • Add data migration (+ form import fixer) to convert defaultValue: [""] into defaultValue: []
  • Check/patch similar components:
    • Radio
    • Selectboxes
@sergei-maertens sergei-maertens added bug Something isn't working topic: form builder labels Apr 2, 2024
@sergei-maertens sergei-maertens added this to the Release 2.6.2 milestone Apr 2, 2024
@sergei-maertens sergei-maertens self-assigned this Apr 2, 2024
@sergei-maertens sergei-maertens added needs-backport Fix must be backported to stable release branch and removed needs-backport Fix must be backported to stable release branch labels Apr 2, 2024
@sergei-maertens
Copy link
Member Author

Removing backport label - JSON can be edited as a workaround and we're explicitly setting up our backend validation to allow it for now.

@sergei-maertens sergei-maertens mentioned this issue Apr 2, 2024
Open
@joeribekker joeribekker assigned Viicos and unassigned sergei-maertens Apr 4, 2024
Viicos added a commit to open-formulieren/formio-builder that referenced this issue Apr 4, 2024
@Viicos
[open-formulieren/open-forms#4084] Fix default value of multiple `sel…
5fc7050 
…ect` component
@Viicos Viicos mentioned this issue Apr 4, 2024
Merged
Viicos added a commit that referenced this issue Apr 4, 2024
@Viicos
[#4084] Add migration to fix multiple select default value
10b7860
@Viicos Viicos mentioned this issue Apr 4, 2024
Merged
Viicos added a commit to open-formulieren/formio-builder that referenced this issue Apr 5, 2024
@Viicos
[open-formulieren/open-forms#4084] Add test
8e4d798
sergei-maertens added a commit to open-formulieren/formio-builder that referenced this issue Apr 5, 2024
@sergei-maertens
Merge pull request #135 from open-formulieren/issue/4084
5303463 
[open-formulieren/open-forms#4084] Fix default value of multiple `select` component
Viicos added a commit that referenced this issue Apr 8, 2024
@Viicos
[#4084] Update to @open-formulieren/formio-builder@0.18.1
7c96053
Viicos added a commit that referenced this issue Apr 9, 2024
@Viicos
[#4084] Add migration to fix multiple select default value
35f2c6c
Viicos added a commit that referenced this issue Apr 9, 2024
@Viicos
[#4084] Update to @open-formulieren/formio-builder@0.18.1
d36b530
Viicos added a commit to open-formulieren/formio-builder that referenced this issue Apr 10, 2024
@Viicos
[open-formulieren/open-forms#4084] Handle selects defaultValue wh…
54992cb 
…en set to `null`
@Viicos Viicos mentioned this issue Apr 10, 2024
Merged
Viicos added a commit to open-formulieren/formio-builder that referenced this issue Apr 10, 2024
@Viicos
[open-formulieren/open-forms#4084] Handle selects defaultValue wh…
1fa3564 
…en set to `null`
Viicos added a commit to open-formulieren/formio-builder that referenced this issue Apr 11, 2024
@Viicos @sergei-maertens
[open-formulieren/open-forms#4084] Use @ts-expect-error
db98741 
Co-authored-by: Sergei Maertens <sergei-maertens@users.noreply.github.com>
sergei-maertens added a commit to open-formulieren/formio-builder that referenced this issue Apr 11, 2024
@sergei-maertens
Merge pull request #138 from open-formulieren/issue/select-null-default
458e1db 
[open-formulieren/open-forms#4084] Handle `select`s `defaultValue` when set to `null`
sergei-maertens added a commit that referenced this issue Apr 16, 2024
@sergei-maertens
⬆️ Upgrade to formio-builder 0.18.2
6533606 
Contains bugfixes for a number of tickets:

* #4084
* #4155
* #3964
@sergei-maertens sergei-maertens mentioned this issue Apr 16, 2024
Merged
sergei-maertens added a commit that referenced this issue Apr 16, 2024
@sergei-maertens
⬆️ Upgrade to formio-builder 0.18.2
8481c3d 
Contains bugfixes for a number of tickets:

* #4084
* #4155
* #3964

Backport-of: #4176
Viicos added a commit that referenced this issue Apr 17, 2024
@Viicos
[#4084] Add migration to fix multiple select default value
74b6c61
Viicos added a commit that referenced this issue Apr 19, 2024
@Viicos
Merge pull request #4121 from open-formulieren/issue/4084
942bfcb 
[#4084] Add migration to fix multiple select default value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Viicos Viicos

Labels
bug Something isn't working topic: form builder
Projects
Development
Archived in project
Milestone
Release 2.7.0
2 participants
@sergei-maertens @Viicos