Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding user variables can crash variables tab #4099

Closed
LaurensBurger opened this issue Apr 3, 2024 · 0 comments · Fixed by #4104
Closed

Adding user variables can crash variables tab #4099

LaurensBurger opened this issue Apr 3, 2024 · 0 comments · Fixed by #4104
Assignees
Labels
bug Something isn't working needs-backport Fix must be backported to stable release branch
Milestone

Comments

@LaurensBurger
Copy link
Collaborator

LaurensBurger commented Apr 3, 2024

Product versie / Product version

2.6.1

Omschrijf het probleem / Describe the bug

Ref: Taiga Utrecht 196

#4069 seems related?
When Objects api (v1) is selected in registration, adding a user variable crashes the variables tab:

ypeError: e.variablesMapping is not iterable
    at onUserDefinedVariableEdit (userDefinedVariableEditHandlers.js:30:54)
    at form-creation-form.js:808:32
    at Proxy.map (<anonymous>)
    at ex (form-creation-form.js:803:73)
    at immer.esm.mjs:1:16170
    at e.produce (immer.esm.mjs:1:16318)
    at immer.esm.mjs:1:16124
    at Object.Oa [as useReducer] (react-dom.production.min.js:170:451)
    at t.useReducer (react.production.min.js:25:274)
    at Di (use-immer.module.js:1:334)

Does not occur when using the new objects api registration or other registration types.

Stappen om te reproduceren / Steps to reproduce

No response

Verwacht gedrag / Expected behavior

No response

Screen resolution

None

Device

None

OS

None

Browser

No response

@LaurensBurger LaurensBurger added bug Something isn't working triage Issue needs to be validated. Remove this label if the issue considered valid. labels Apr 3, 2024
@joeribekker joeribekker added this to the Release 2.6.2 milestone Apr 3, 2024
@Viicos Viicos removed the triage Issue needs to be validated. Remove this label if the issue considered valid. label Apr 3, 2024
@sergei-maertens sergei-maertens added the needs-backport Fix must be backported to stable release branch label Apr 3, 2024
sergei-maertens added a commit that referenced this issue Apr 4, 2024
[#4099] Fix crash when using legacy Objects API registration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-backport Fix must be backported to stable release branch
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants