Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change GovMetric to use seperate IDs for end of list and abort list #4115

Closed
2 tasks done
joeribekker opened this issue Apr 4, 2024 · 1 comment · Fixed by #4164, open-formulieren/open-forms-sdk#670, #4206 or open-formulieren/open-forms-sdk#675
Assignees
Labels
enhancement needs-backport Fix must be backported to stable release branch
Milestone

Comments

@joeribekker
Copy link
Contributor

joeribekker commented Apr 4, 2024

  • We need to split source ID into abort source ID and feedback source ID.
  • Show smileys directly on the confirmation page

image

Vendor 1

Clicking stop replaces the page with: https://websurveys2.govmetric.com/theme/kf/9990006?Q_TYPE=form&Q_ZT_ID=135&Q_PAGE=confirm

<section class="ng-star-inserted">
    <h2>Wat vindt u van dit formulier?</h2><app-form-gov-metric class="flex form-field-responsive">
        <div id="sidebar" class="gm_sidebar w-form-field mt-2 mb-6">
            <ul class="flex justify-between p-0 m-0">
                <li class="kif_col [&amp;.kif\_col]:block [&amp;.kif\_col]:w-auto max-w-[31%] ml-2"><a rel="nofollow"
                        class="gm_sidebar_anchor"
                        href="https://websurveys2.govmetric.com/theme/kf/2652?Q_TYPE=form&amp;Q_ZT_ID=135&amp;Q_PAGE=complete&amp;Q_RATINGID=3"
                        title="Beoordeel dit formulier als goed"><img src="assets/images/gov-metric/Good.svg"
                            class="h-11 w-11 m-auto" alt="Groene smiley (positief)"></a><strong>Goed</strong></li>
                <li class="kif_col [&amp;.kif\_col]:block [&amp;.kif\_col]:w-auto max-w-[31%]"><a rel="nofollow"
                        class="gm_sidebar_anchor"
                        href="https://websurveys2.govmetric.com/theme/kf/2652?Q_TYPE=form&amp;Q_ZT_ID=135&amp;Q_PAGE=complete&amp;Q_RATINGID=2"
                        title="Beoordeel dit formulier als matig"><img src="assets/images/gov-metric/Average.svg"
                            class="h-11 w-11 m-auto" alt="Oranje smiley (neutraal)"></a><strong>Matig</strong></li>
                <li class="kif_col [&amp;.kif\_col]:block [&amp;.kif\_col]:w-auto max-w-[31%] mr-2"><a rel="nofollow"
                        class="gm_sidebar_anchor"
                        href="https://websurveys2.govmetric.com/theme/kf/2652?Q_TYPE=form&amp;Q_ZT_ID=135&amp;Q_PAGE=complete&amp;Q_RATINGID=4"
                        title="Beoordeel dit formulier als slecht"><img src="assets/images/gov-metric/Poor.svg"
                            class="h-11 w-11 m-auto" alt="Rode smiley (negatief)"></a><strong>Slecht</strong></li>
            </ul>
        </div>
    </app-form-gov-metric>
</section>

Vendor 2

<div id="feedback_tool" class="gm_sidebar">
    <h1>Wat vond u van dit formulier?</h1>
    <p class="select_your_choice">Maak uw keuze:</p>
        <div class="kif_wrap">
        <div class="kif_item">
            <a href="https://websurveys2.govmetric.com/theme/kf/2652?GUID=''&amp;Q_RATINGID=3" class="gm_sidebar_anchor" title="Beoordeel deze formulier als goed" role="button" rel="nofollow">
                <img src="https://websurveys2.govmetric.com/imgs/smileys/svg/standard/smiley-dark-green.svg" alt="Groene smiley (positief)">
            </a>
            <p class="option_good">Goed</p>
        </div>
        <div class="kif_item">
            <a href="https://websurveys2.govmetric.com/theme/kf/2652?GUID=''&amp;Q_RATINGID=2" class="gm_sidebar_anchor" title="Beoordeel deze formulier als matig" role="button" rel="nofollow">
                <img src="https://websurveys2.govmetric.com/imgs/smileys/svg/standard/smiley-orange.svg" alt="Oranje smiley (neutraal)">
            </a>
            <p class="option_mediocre">Matig</p>
        </div>
        <div class="kif_item">
            <a href="https://websurveys2.govmetric.com/theme/kf/2652?GUID=''&amp;Q_RATINGID=4" class="gm_sidebar_anchor" title="Beoordeel deze formulier als slecht" role="button" rel="nofollow">
                <img src="https://websurveys2.govmetric.com/imgs/smileys/svg/standard/smiley-dark-red.svg" alt="Rode smiley (negatief)">
            </a>
            <p class="option_bad">Slecht</p>
        </div>
    </div>
    </div>
@joeribekker joeribekker added the triage Issue needs to be validated. Remove this label if the issue considered valid. label Apr 4, 2024
@joeribekker joeribekker added this to the Release 2.6.3 milestone Apr 4, 2024
@joeribekker joeribekker added enhancement and removed triage Issue needs to be validated. Remove this label if the issue considered valid. labels Apr 8, 2024
@sergei-maertens sergei-maertens added the needs-backport Fix must be backported to stable release branch label Apr 8, 2024
@sergei-maertens
Copy link
Member

-> needs to be a PR against stable/2.6.x and forward port it then to sort out migrations

SilviaAmAm added a commit that referenced this issue Apr 12, 2024
Added to support having different IDs for when the form is finished or aborted
SilviaAmAm added a commit that referenced this issue Apr 12, 2024
SilviaAmAm added a commit that referenced this issue Apr 12, 2024
Added to support having different IDs for when the form is finished or aborted
SilviaAmAm added a commit that referenced this issue Apr 12, 2024
SilviaAmAm added a commit that referenced this issue Apr 12, 2024
SilviaAmAm added a commit that referenced this issue Apr 12, 2024
Added to support having different IDs for when the form is finished or aborted
SilviaAmAm added a commit that referenced this issue Apr 12, 2024
SilviaAmAm added a commit that referenced this issue Apr 12, 2024
SilviaAmAm added a commit to open-formulieren/open-forms-sdk that referenced this issue Apr 12, 2024
SilviaAmAm added a commit to open-formulieren/open-forms-sdk that referenced this issue Apr 12, 2024
SilviaAmAm added a commit to open-formulieren/open-forms-sdk that referenced this issue Apr 12, 2024
SilviaAmAm added a commit to open-formulieren/open-forms-sdk that referenced this issue Apr 12, 2024
SilviaAmAm added a commit to open-formulieren/open-forms-sdk that referenced this issue Apr 12, 2024
SilviaAmAm added a commit to open-formulieren/open-forms-sdk that referenced this issue Apr 12, 2024
SilviaAmAm added a commit to open-formulieren/open-forms-sdk that referenced this issue Apr 15, 2024
SilviaAmAm added a commit to open-formulieren/open-forms-sdk that referenced this issue Apr 16, 2024
SilviaAmAm added a commit that referenced this issue Apr 19, 2024
Added to support having different IDs for when the form is finished or aborted
SilviaAmAm added a commit that referenced this issue Apr 19, 2024
SilviaAmAm added a commit that referenced this issue Apr 19, 2024
SilviaAmAm added a commit that referenced this issue Apr 19, 2024
SilviaAmAm added a commit that referenced this issue Apr 19, 2024
Added to support having different IDs for when the form is finished or aborted
SilviaAmAm added a commit that referenced this issue Apr 19, 2024
SilviaAmAm added a commit that referenced this issue Apr 19, 2024
SilviaAmAm added a commit that referenced this issue Apr 19, 2024
Added to support having different IDs for when the form is finished or aborted
SilviaAmAm added a commit that referenced this issue Apr 19, 2024
SilviaAmAm added a commit that referenced this issue Apr 19, 2024
SilviaAmAm added a commit that referenced this issue Apr 19, 2024
…-changes

[#4115] Extra source ID / secure GUID for GovMetric
SilviaAmAm added a commit that referenced this issue Apr 19, 2024
SilviaAmAm added a commit to open-formulieren/open-forms-sdk that referenced this issue Apr 19, 2024
SilviaAmAm added a commit to open-formulieren/open-forms-sdk that referenced this issue Apr 19, 2024
SilviaAmAm added a commit to open-formulieren/open-forms-sdk that referenced this issue Apr 19, 2024
SilviaAmAm added a commit to open-formulieren/open-forms-sdk that referenced this issue Apr 19, 2024
SilviaAmAm added a commit to open-formulieren/open-forms-sdk that referenced this issue Apr 19, 2024
SilviaAmAm added a commit to open-formulieren/open-forms-sdk that referenced this issue Apr 19, 2024
SilviaAmAm added a commit to open-formulieren/open-forms-sdk that referenced this issue Apr 19, 2024
@SilviaAmAm SilviaAmAm reopened this Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment