Fix validation of conditionally visible components inside repeating groups #4126
Assignees
Labels
bug
Something isn't working
needs-backport
Fix must be backported to stable release branch
owner: den-haag
Milestone
Comments
sergei-maertens
added
the
needs-backport
sergei-maertens
added a commit
that referenced
this issue
Apr 5, 2024
We cannot simply use ListField, as that applies the same child serializer for every item inside the array of values, but the field configuration of the child actually changes depending on the values passed in (some fields may be hidden, and that disables their validations entirely). Note the disclaimer about rest_framework.fields.Field.__repr__, this method behaves unexpectedly because it doesn't report the current values of args/kwargs, but the values at the time of instance creation.
sergei-maertens
added a commit
that referenced
this issue
Apr 8, 2024
We cannot simply use ListField, as that applies the same child serializer for every item inside the array of values, but the field configuration of the child actually changes depending on the values passed in (some fields may be hidden, and that disables their validations entirely). Note the disclaimer about rest_framework.fields.Field.__repr__, this method behaves unexpectedly because it doesn't report the current values of args/kwargs, but the values at the time of instance creation.
sergei-maertens
added a commit
that referenced
this issue
Apr 8, 2024
We cannot simply use ListField, as that applies the same child serializer for every item inside the array of values, but the field configuration of the child actually changes depending on the values passed in (some fields may be hidden, and that disables their validations entirely). Note the disclaimer about rest_framework.fields.Field.__repr__, this method behaves unexpectedly because it doesn't report the current values of args/kwargs, but the values at the time of instance creation.
sergei-maertens
added a commit
that referenced
this issue
Apr 8, 2024
sergei-maertens
added a commit
that referenced
this issue
Apr 8, 2024
We cannot simply use ListField, as that applies the same child serializer for every item inside the array of values, but the field configuration of the child actually changes depending on the values passed in (some fields may be hidden, and that disables their validations entirely). Note the disclaimer about rest_framework.fields.Field.__repr__, this method behaves unexpectedly because it doesn't report the current values of args/kwargs, but the values at the time of instance creation. Backport-of: #4125
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Taiga DH 674
Too complicated (and edge case) for 2.6.2, but needs to be in 2.6.3.
If you have a component inside a repeating group that is
{validate: {required: true}}and conditionally visible, the frontend skips the validation but the backend is not able to see that the validation should be skipped.This is complicated because every row in the list behaves independent from its siblings.
The text was updated successfully, but these errors were encountered: