Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply validations (except for required) on submission step PUT endpoint #4143

Closed
sergei-maertens opened this issue Apr 9, 2024 · 0 comments · Fixed by #4144
Closed

Apply validations (except for required) on submission step PUT endpoint #4143

sergei-maertens opened this issue Apr 9, 2024 · 0 comments · Fixed by #4144
Assignees
@sergei-maertens
Milestone
Release 2.6.3

Comments

@sergei-maertens
Copy link
Member

This should help enforce invalid data input (e.g. according to regex) while still allowing pausing of forms (which must support incomplete data).
@sergei-maertens sergei-maertens added this to the Release 2.6.3 milestone Apr 9, 2024
@sergei-maertens sergei-maertens self-assigned this Apr 9, 2024
sergei-maertens added a commit that referenced this issue Apr 9, 2024
@sergei-maertens
✅ [#4143] Add test for desired step-level validation behaviour
0c1a624 
We want to ignore the validate.required property of each component,
while applying the rest of the validations.
sergei-maertens added a commit that referenced this issue Apr 9, 2024
@sergei-maertens
🦺 [#4143] Run a stripped-down version of input data validation on sub…
895744d 
…mission step PUT

Hopefully this doesn't break pausing of forms.
sergei-maertens added a commit that referenced this issue Apr 9, 2024
@sergei-maertens
💚 [#4143] Fix broken test
f195285 
The radio component definition was not correct.
@sergei-maertens sergei-maertens mentioned this issue Apr 9, 2024
Merged
sergei-maertens added a commit that referenced this issue Apr 9, 2024
@sergei-maertens
✅ [#4143] Update e2e validation test logic
99cde56 
Since step data validation is now performed, we may get early HTTP 400
errors and need to assert those differently than if the data is
accepted by the PUT call.
sergei-maertens added a commit that referenced this issue Apr 9, 2024
@sergei-maertens
✅ [#4143] Add test for desired step-level validation behaviour
83ce513 
We want to ignore the validate.required property of each component,
while applying the rest of the validations.
sergei-maertens added a commit that referenced this issue Apr 9, 2024
@sergei-maertens
🦺 [#4143] Run a stripped-down version of input data validation on sub…
683ecf6 
…mission step PUT

Hopefully this doesn't break pausing of forms.
sergei-maertens added a commit that referenced this issue Apr 9, 2024
@sergei-maertens
💚 [#4143] Fix broken test
f860d92 
The radio component definition was not correct.
sergei-maertens added a commit that referenced this issue Apr 9, 2024
@sergei-maertens
✅ [#4143] Update e2e validation test logic
a19a2ca 
Since step data validation is now performed, we may get early HTTP 400
errors and need to assert those differently than if the data is
accepted by the PUT call.
sergei-maertens added a commit that referenced this issue Apr 9, 2024
@sergei-maertens
✅ [#4143] Add test for desired step-level validation behaviour
eb13be8 
We want to ignore the validate.required property of each component,
while applying the rest of the validations.
sergei-maertens added a commit that referenced this issue Apr 9, 2024
@sergei-maertens
🦺 [#4143] Run a stripped-down version of input data validation on sub…
e0210f7 
…mission step PUT

Hopefully this doesn't break pausing of forms.
sergei-maertens added a commit that referenced this issue Apr 9, 2024
@sergei-maertens
💚 [#4143] Fix broken test
1b55433 
The radio component definition was not correct.
sergei-maertens added a commit that referenced this issue Apr 9, 2024
@sergei-maertens
✅ [#4143] Update e2e validation test logic
e924303 
Since step data validation is now performed, we may get early HTTP 400
errors and need to assert those differently than if the data is
accepted by the PUT call.
sergei-maertens added a commit that referenced this issue Apr 9, 2024
@sergei-maertens
🦺 [#4143] Run a stripped-down version of input data validation on sub…
2310f9e 
…mission step PUT

Hopefully this doesn't break pausing of forms.

Backport-of: #4144
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sergei-maertens sergei-maertens

Labels
None yet
Projects
Development
Archived in project
Milestone
Release 2.6.3
Development

Successfully merging a pull request may close this issue.

Apply partial input validation on submission step put open-formulieren/open-forms
1 participant
@sergei-maertens