Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Objects API v2 registration crashes with hidden fields #4202

Closed
Viicos opened this issue Apr 18, 2024 · 0 comments · Fixed by #4203
Closed

Objects API v2 registration crashes with hidden fields #4202

Viicos opened this issue Apr 18, 2024 · 0 comments · Fixed by #4203
Assignees
Labels
bug Something isn't working needs-backport Fix must be backported to stable release branch
Milestone

Comments

@Viicos
Copy link
Contributor

Viicos commented Apr 18, 2024

Product versie / Product version

latest

Omschrijf het probleem / Describe the bug

Sentry 355282

Stappen om te reproduceren / Steps to reproduce

  1. Create a form with a hidden number field, do not map it to any target
  2. Submit a form
  3. Registration will crash:
error raised while processing, details below.
 Target-spec trace (most recent last):
 - Target: {'fieldSet': {'textField': 'aaa'}}
 - Spec: 'number'
glom.core.PathAccessError: could not access 'number', part 0 of Path('number'), got error: KeyError('number')

Verwacht gedrag / Expected behavior

No response

Screen resolution

None

Device

None

OS

None

Browser

No response

@Viicos Viicos added bug Something isn't working triage Issue needs to be validated. Remove this label if the issue considered valid. labels Apr 18, 2024
Viicos added a commit that referenced this issue Apr 19, 2024
@Viicos Viicos added needs-backport Fix must be backported to stable release branch and removed triage Issue needs to be validated. Remove this label if the issue considered valid. labels Apr 19, 2024
@Viicos Viicos added this to the Release 2.6.5 milestone Apr 19, 2024
@Viicos Viicos self-assigned this Apr 19, 2024
Viicos added a commit that referenced this issue Apr 19, 2024
…-hidden

 [#4202] Fix Objects API registration v2 crash with hidden fields
Viicos added a commit that referenced this issue Apr 23, 2024
[#4202] Fix Objects API registration v2 crash with hidden fields
Viicos added a commit that referenced this issue May 21, 2024
sergei-maertens added a commit that referenced this issue May 21, 2024
* [#4302] Small typing improvement

* [#4302] Add date to cosign data

This only applies to new cosign flow

* [#4302] Add registration variables related to cosign

* ♻️ Simplify (regression) tests

* [#4202] Add regression test

* [#4302] Add/update tests

* [#4302] Support cosign data for V1 registration

* [#4302] Add tests for V1 registration

* [#4302] Feedback

* [#4302] Add documentation

---------

Co-authored-by: Sergei Maertens <sergei@maykinmedia.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-backport Fix must be backported to stable release branch
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant