-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove form copy endpoint #4236
Comments
This comment was marked as resolved.
This comment was marked as resolved.
Viicos
added a commit
that referenced
this issue
Apr 29, 2024
There exists an endpoint now to copy forms, but our own JS does not make use of it, instead, we submit the POST action to the backend to copy a form.
Viicos
added a commit
that referenced
this issue
Apr 30, 2024
There exists an endpoint now to copy forms, but our own JS does not make use of it, instead, we submit the POST action to the backend to copy a form.
sergei-maertens
added a commit
that referenced
this issue
May 1, 2024
By specifying a registration backend, we don't need to check the GlobalConfiguration solo model (via the factories) and thus don't risk accessing any cached data that could break test isolation. It's a bit weird that this factory helper does DB and cache IO to select an enabled plugin, we should probably clean that up in a later stage.
sergei-maertens
pushed a commit
that referenced
this issue
May 1, 2024
There exists an endpoint now to copy forms, but our own JS does not make use of it, instead, we submit the POST action to the backend to copy a form.
sergei-maertens
pushed a commit
that referenced
this issue
May 1, 2024
sergei-maertens
added a commit
that referenced
this issue
May 1, 2024
By specifying a registration backend, we don't need to check the GlobalConfiguration solo model (via the factories) and thus don't risk accessing any cached data that could break test isolation. It's a bit weird that this factory helper does DB and cache IO to select an enabled plugin, we should probably clean that up in a later stage.
sergei-maertens
added a commit
that referenced
this issue
May 1, 2024
[#4236] Remove form copy API endpoint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There exists an endpoint now to copy forms, but our own JS does not make use of it, instead, we submit the POST action to the backend to copy a form.
Since this endpoint is private API, we can remove it without breaking our semver policy.
Tasks
copy
endpointform.copy
method rather POST-ing to the copy endpointThe text was updated successfully, but these errors were encountered: