-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DMN improvements for demo #4269
Labels
enhancement
needs-backport
Fix must be backported to stable release branch
owner: den-haag
topic: DMN
Milestone
Comments
Findings of research done for this ticket:
|
sergei-maertens
added a commit
that referenced
this issue
May 8, 2024
sergei-maertens
added a commit
that referenced
this issue
May 8, 2024
The input expressions require additional parsing to properly extract the required input variables for a decision table.
sergei-maertens
added a commit
that referenced
this issue
May 8, 2024
This should help form builders configure DMN tables to see which input expressions are expected by the decision engine.
sergei-maertens
added a commit
that referenced
this issue
May 8, 2024
Input expressions can be complex with the actual requested variable buried deep inside. We leverage the 'feelin' library to parse FEEL expressions so that we can extract the actual (likely) expected variables and combine this information with our retrieved input clauses. This result is used to build a list of DMN variables for input mapping - this list is ordered to put labeled literal variables at the top, followed by the extracted unlabeled variables, and finally the legal identifiers that are labeled but likely complex/edge cases. This implements the DMN 1.3 FEEL identifier specification to select candidates.
sergei-maertens
added a commit
that referenced
this issue
May 8, 2024
Use the existing VariableSelection component to render a dropdown of available Open Forms variables. Added an accessible label to the dropdowns in the mapping tables.
sergei-maertens
added a commit
that referenced
this issue
May 8, 2024
Updated the assertions for the existing stories so that the interaction tests pass again. Added a story for the complex expression cases.
sergei-maertens
added a commit
that referenced
this issue
May 8, 2024
sergei-maertens
changed the title
DMN improvements (sergei will fill in)
DMN improvements for demo
May 8, 2024
9 tasks
sergei-maertens
added a commit
that referenced
this issue
May 8, 2024
This has the correct input dependency resolution implementation.
sergei-maertens
added a commit
that referenced
this issue
May 8, 2024
sergei-maertens
added a commit
that referenced
this issue
May 8, 2024
sergei-maertens
added a commit
that referenced
this issue
May 8, 2024
sergei-maertens
added a commit
that referenced
this issue
May 8, 2024
The input expressions require additional parsing to properly extract the required input variables for a decision table.
sergei-maertens
added a commit
that referenced
this issue
May 8, 2024
This should help form builders configure DMN tables to see which input expressions are expected by the decision engine.
sergei-maertens
added a commit
that referenced
this issue
May 8, 2024
Input expressions can be complex with the actual requested variable buried deep inside. We leverage the 'feelin' library to parse FEEL expressions so that we can extract the actual (likely) expected variables and combine this information with our retrieved input clauses. This result is used to build a list of DMN variables for input mapping - this list is ordered to put labeled literal variables at the top, followed by the extracted unlabeled variables, and finally the legal identifiers that are labeled but likely complex/edge cases. This implements the DMN 1.3 FEEL identifier specification to select candidates.
sergei-maertens
added a commit
that referenced
this issue
May 8, 2024
Use the existing VariableSelection component to render a dropdown of available Open Forms variables. Added an accessible label to the dropdowns in the mapping tables.
sergei-maertens
added a commit
that referenced
this issue
May 8, 2024
Updated the assertions for the existing stories so that the interaction tests pass again. Added a story for the complex expression cases.
sergei-maertens
added a commit
that referenced
this issue
May 8, 2024
sergei-maertens
added a commit
that referenced
this issue
May 8, 2024
This has the correct input dependency resolution implementation.
sergei-maertens
added a commit
that referenced
this issue
May 8, 2024
sergei-maertens
added a commit
that referenced
this issue
May 8, 2024
sergei-maertens
added
the
needs-backport
Fix must be backported to stable release branch
label
May 8, 2024
While these are enhancements, they are critical enhancements to be backported because in its current state, DMN integration is not usable. |
sergei-maertens
added a commit
that referenced
this issue
May 8, 2024
sergei-maertens
added a commit
that referenced
this issue
May 8, 2024
The input expressions require additional parsing to properly extract the required input variables for a decision table.
sergei-maertens
added a commit
that referenced
this issue
May 8, 2024
This should help form builders configure DMN tables to see which input expressions are expected by the decision engine.
sergei-maertens
added a commit
that referenced
this issue
May 8, 2024
Input expressions can be complex with the actual requested variable buried deep inside. We leverage the 'feelin' library to parse FEEL expressions so that we can extract the actual (likely) expected variables and combine this information with our retrieved input clauses. This result is used to build a list of DMN variables for input mapping - this list is ordered to put labeled literal variables at the top, followed by the extracted unlabeled variables, and finally the legal identifiers that are labeled but likely complex/edge cases. This implements the DMN 1.3 FEEL identifier specification to select candidates.
sergei-maertens
added a commit
that referenced
this issue
May 8, 2024
Use the existing VariableSelection component to render a dropdown of available Open Forms variables. Added an accessible label to the dropdowns in the mapping tables.
sergei-maertens
added a commit
that referenced
this issue
May 8, 2024
Updated the assertions for the existing stories so that the interaction tests pass again. Added a story for the complex expression cases.
sergei-maertens
added a commit
that referenced
this issue
May 8, 2024
sergei-maertens
added a commit
that referenced
this issue
May 8, 2024
This has the correct input dependency resolution implementation.
sergei-maertens
added a commit
that referenced
this issue
May 8, 2024
sergei-maertens
added a commit
that referenced
this issue
May 8, 2024
sergei-maertens
added a commit
that referenced
this issue
May 8, 2024
sergei-maertens
added a commit
that referenced
this issue
May 8, 2024
The input expressions require additional parsing to properly extract the required input variables for a decision table.
sergei-maertens
added a commit
that referenced
this issue
May 8, 2024
This should help form builders configure DMN tables to see which input expressions are expected by the decision engine.
sergei-maertens
added a commit
that referenced
this issue
May 8, 2024
Input expressions can be complex with the actual requested variable buried deep inside. We leverage the 'feelin' library to parse FEEL expressions so that we can extract the actual (likely) expected variables and combine this information with our retrieved input clauses. This result is used to build a list of DMN variables for input mapping - this list is ordered to put labeled literal variables at the top, followed by the extracted unlabeled variables, and finally the legal identifiers that are labeled but likely complex/edge cases. This implements the DMN 1.3 FEEL identifier specification to select candidates.
sergei-maertens
added a commit
that referenced
this issue
May 8, 2024
Use the existing VariableSelection component to render a dropdown of available Open Forms variables. Added an accessible label to the dropdowns in the mapping tables.
sergei-maertens
added a commit
that referenced
this issue
May 8, 2024
Updated the assertions for the existing stories so that the interaction tests pass again. Added a story for the complex expression cases.
sergei-maertens
added a commit
that referenced
this issue
May 8, 2024
sergei-maertens
added a commit
that referenced
this issue
May 8, 2024
This has the correct input dependency resolution implementation.
sergei-maertens
added a commit
that referenced
this issue
May 8, 2024
sergei-maertens
added a commit
that referenced
this issue
May 8, 2024
sergei-maertens
added a commit
that referenced
this issue
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
needs-backport
Fix must be backported to stable release branch
owner: den-haag
topic: DMN
Some improvements to the DMN UI
a + b
expressions in an input expression is... uncommon. We don't necessarily need to support this right now.Useful resource: https://consulting.camunda.com/dmn-simulator/
Tasks
a + b
FEEL expression -> varsa
andb
)The text was updated successfully, but these errors were encountered: