📌 Pin lxml to not use binary wheels #2247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in preparation to upgrading python3-saml and then lxml to their latest versions. lxml breaks on some edge cases becaues it was statically built against a different libxml2 than *other* xml-based tooling using at runtime ( because that's dynamically linked), causing some tree lookups to fail. * python3-saml issue: SAML-Toolkits/python3-saml#292 * upstream bug: https://bugs.launchpad.net/lxml/+bug/1960668
sergei-maertens
force-pushed
the
feature/upgrade-lxml
branch
from
0dabe18
to
57940b1
Compare
SilviaAmAm
approved these changes
Oct 28, 2022
nkukard
added a commit
to nkukard/PowerDNS-Admin
that referenced
this pull request
Mar 14, 2023
… built against old libxml2 This fixes PowerDNS-Admin#1442 and closes PowerDNS-Admin#1433. The issue with python3-saml not working is because the binary lxml wheel is built against a different version of libxml2. ``--no-binary lxml`` can be used to fix this and python3-saml will work. for references check these: - SAML-Toolkits/python3-saml#292 - https://bugs.launchpad.net/lxml/+bug/1960668 - open-formulieren/open-forms#2247
nkukard
added a commit
to nkukard/PowerDNS-Admin
that referenced
this pull request
Mar 14, 2023
… built against old libxml2 This fixes PowerDNS-Admin#1442 and closes PowerDNS-Admin#1433. The issue with python3-saml not working is because the binary lxml wheel is built against a different version of libxml2. ``--no-binary lxml`` can be used to fix this and python3-saml will work. for references check these: - SAML-Toolkits/python3-saml#292 - https://bugs.launchpad.net/lxml/+bug/1960668 - open-formulieren/open-forms#2247 ``` Tested on: - ubuntu:23.04 - WORKING - ubuntu:22.10 - WORKING - ubuntu:22.04 - WORKING - ubuntu:20.04 - WORKING - ubuntu:18.04 - NOT WORKING - pip usage error with -r requirements.txt - debian:10 - WORKING - debian:11 - WORKING - alpine:edge - WORKING - alpine:3.17 - WORKING - alpine:3.16 - WORKING - alpine:3.15 - WORKING - alpine:3.14 - WORKING - rockylinux:9 - WORKING - rockylinux:8 - NOT WORKING - pip usage error with -r requirements.txt - almalinux:9 - WORKING - almalinux:8 - NOT WORKING - pip usage error with -r requirements.txt - fedora:36 - WORKING - fedora:37 - WORKING - fedora:38 - WORKING - fedora:39 - WORKING ```
nkukard
added a commit
to nkukard/PowerDNS-Admin
that referenced
this pull request
Mar 14, 2023
Fixes Python 3.11 incompatibility using ancient lxml binary PyPI built against old libxml2. This fixes PowerDNS-Admin#1442 and closes PowerDNS-Admin#1433. The issue with python3-saml not working is because the binary lxml wheel is built against a different version of libxml2. ``--no-binary lxml`` can be used to fix this and python3-saml will work. for references check these: - SAML-Toolkits/python3-saml#292 - https://bugs.launchpad.net/lxml/+bug/1960668 - open-formulieren/open-forms#2247 ``` Tested on: - ubuntu:23.04 - WORKING - ubuntu:22.10 - WORKING - ubuntu:22.04 - WORKING - ubuntu:20.04 - WORKING - ubuntu:18.04 - NOT WORKING - pip usage error with -r requirements.txt - debian:10 - WORKING - debian:11 - WORKING - alpine:edge - WORKING - alpine:3.17 - WORKING - alpine:3.16 - WORKING - alpine:3.15 - WORKING - alpine:3.14 - WORKING - rockylinux:9 - WORKING - rockylinux:8 - NOT WORKING - pip usage error with -r requirements.txt - almalinux:9 - WORKING - almalinux:8 - NOT WORKING - pip usage error with -r requirements.txt - fedora:36 - WORKING - fedora:37 - WORKING - fedora:38 - WORKING - fedora:39 - WORKING ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation to upgrading python3-saml and then lxml to their latest versions.
lxml breaks on some edge cases becaues it was statically built against a different libxml2 than other xml-based tooling using at runtime ( because that's dynamically linked), causing some tree lookups to fail.