Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1530] Confirmation email with CC on cosign #3157

Merged
merged 11 commits into from Jun 16, 2023

Conversation

SilviaAmAm
Copy link
Contributor

@SilviaAmAm SilviaAmAm commented Jun 14, 2023

Fixes #1530

@SilviaAmAm SilviaAmAm marked this pull request as draft June 14, 2023 16:00
@SilviaAmAm SilviaAmAm force-pushed the feature/1530-confirmation-email-cc branch from 1658c82 to 7636075 Compare June 15, 2023 10:47
@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (64ffc8b) 94.49% compared to head (fceba71) 94.50%.

❗ Current head fceba71 differs from pull request most recent head c906656. Consider uploading reports for the commit c906656 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3157   +/-   ##
=======================================
  Coverage   94.49%   94.50%           
=======================================
  Files         609      611    +2     
  Lines       19097    19120   +23     
  Branches     2178     2180    +2     
=======================================
+ Hits        18046    18069   +23     
  Misses        759      759           
  Partials      292      292           
Impacted Files Coverage Δ
src/openforms/config/models.py 96.85% <ø> (ø)
src/openforms/emails/confirmation_emails.py 100.00% <ø> (ø)
src/openforms/emails/models.py 90.90% <ø> (ø)
src/openforms/emails/utils.py 100.00% <ø> (ø)
...rc/openforms/template/backends/sandboxed_django.py 100.00% <ø> (ø)
...penforms/emails/templatetags/cosign_information.py 100.00% <100.00%> (ø)
src/openforms/submissions/tasks/co_sign.py 100.00% <100.00%> (ø)
src/openforms/submissions/tasks/emails.py 100.00% <100.00%> (ø)
src/openforms/submissions/utils.py 93.06% <100.00%> (+0.21%) ⬆️
src/openforms/utils/regex.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@SilviaAmAm SilviaAmAm marked this pull request as ready for review June 15, 2023 12:32
@SilviaAmAm SilviaAmAm marked this pull request as draft June 15, 2023 12:34
Comment on lines +16 to +17
for template in templates:
template.content = add_cosign_info_templatetag(template.content)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At some point we could do this with one query: django/django#12438

@SilviaAmAm SilviaAmAm marked this pull request as ready for review June 15, 2023 13:03
src/openforms/emails/utils.py Outdated Show resolved Hide resolved
src/openforms/emails/tests/test_migrations.py Show resolved Hide resolved
src/openforms/utils/regex.py Outdated Show resolved Hide resolved
@SilviaAmAm SilviaAmAm force-pushed the feature/1530-confirmation-email-cc branch from f0b0c60 to d4059ee Compare June 16, 2023 09:54
Copy link
Member

@sergei-maertens sergei-maertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some Dutch language remarks left in the docs.

docs/manual/templates.rst Outdated Show resolved Hide resolved
docs/manual/templates.rst Outdated Show resolved Hide resolved
docs/manual/templates.rst Outdated Show resolved Hide resolved
@SilviaAmAm SilviaAmAm merged commit 325ce78 into master Jun 16, 2023
17 checks passed
@SilviaAmAm SilviaAmAm deleted the feature/1530-confirmation-email-cc branch June 16, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Co-signing does not work with a DigiD Gateway (e.g. OIDC) or DigiD SSO
2 participants