Fix plugin validators being AND-ed instead of OR-ed in the backend validation. #4136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergei-maertens
added
the
needs-backport
Viicos
reviewed
Apr 8, 2024
I had the wrong issue number, should have been 4131 |
The frontend applies OR-logic when evaluating validation plugins on a Formio component, which the backend did not replicate correctly.
sergei-maertens
force-pushed
the
issue/4121-plugin-validators-must-be-or-instead-of-and
branch
from
61eb2be
to
107845c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4136 +/- ##
==========================================
+ Coverage 96.09% 96.10% +0.01%
==========================================
Files 730 730
Lines 23130 23134 +4
Branches 2705 2699 -6
==========================================
+ Hits 22226 22234 +8
+ Misses 641 638 -3
+ Partials 263 262 -1 ☔ View full report in Codecov by Sentry. |
sergei-maertens
deleted the
issue/4121-plugin-validators-must-be-or-instead-of-and
branch
sergei-maertens
added a commit
that referenced
this pull request
Apr 8, 2024
The frontend applies OR-logic when evaluating validation plugins on a Formio component, which the backend did not replicate correctly. Backport-of: #4136
|
Backported to 2.6.x via 5e8bb37 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4131
I am schtewpid