Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#72] Add backend validation for iban component #4231

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

vaszig
Copy link
Contributor

@vaszig vaszig commented Apr 26, 2024

Closes #72 partially

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.16%. Comparing base (8b36d3f) to head (05474d2).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4231   +/-   ##
=======================================
  Coverage   96.16%   96.16%           
=======================================
  Files         732      732           
  Lines       23445    23467   +22     
  Branches     2737     2740    +3     
=======================================
+ Hits        22546    22568   +22     
  Misses        637      637           
  Partials      262      262           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vaszig vaszig force-pushed the task/72-backend-validation-iban-component branch 2 times, most recently from 89f1611 to a26b658 Compare April 29, 2024 10:47
Copy link
Member

@sergei-maertens sergei-maertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to submit this feedback yesterday, sorry!

src/openforms/formio/components/custom.py Outdated Show resolved Hide resolved
src/openforms/formio/tests/validation/test_iban.py Outdated Show resolved Hide resolved
@vaszig vaszig force-pushed the task/72-backend-validation-iban-component branch from a26b658 to 05474d2 Compare April 30, 2024 14:21
@sergei-maertens sergei-maertens merged commit caadc57 into master Apr 30, 2024
27 checks passed
@sergei-maertens sergei-maertens deleted the task/72-backend-validation-iban-component branch April 30, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As developer I want to implement frontend and backend validation of form fields
2 participants