Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#72] Add backend validation for licenseplate component #4232

Merged

Conversation

vaszig
Copy link
Contributor

@vaszig vaszig commented Apr 26, 2024

Closes #72 partially

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 96.16%. Comparing base (caadc57) to head (74f9184).

Files Patch % Lines
src/openforms/formio/components/custom.py 85.71% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4232      +/-   ##
==========================================
- Coverage   96.16%   96.16%   -0.01%     
==========================================
  Files         732      732              
  Lines       23467    23479      +12     
  Branches     2740     2743       +3     
==========================================
+ Hits        22568    22578      +10     
  Misses        637      637              
- Partials      262      264       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vaszig vaszig force-pushed the task/72-backend-validation-licenseplate-component branch 3 times, most recently from 24d748e to e5911c1 Compare April 29, 2024 13:00
@vaszig vaszig force-pushed the task/72-backend-validation-licenseplate-component branch from e5911c1 to 36e6425 Compare April 30, 2024 14:31
@sergei-maertens sergei-maertens force-pushed the task/72-backend-validation-licenseplate-component branch from 36e6425 to 74f9184 Compare April 30, 2024 16:18
@sergei-maertens sergei-maertens merged commit dcd8645 into master May 1, 2024
25 of 27 checks passed
@sergei-maertens sergei-maertens deleted the task/72-backend-validation-licenseplate-component branch May 1, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As developer I want to implement frontend and backend validation of form fields
2 participants