Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch migration crashes because of broken configuration #4252

Merged
merged 1 commit into from
May 1, 2024

Conversation

sergei-maertens
Copy link
Member

@sergei-maertens sergei-maertens commented May 1, 2024

Closes #4247

Through manual editing or form changes without matching logic updates, the formio configuration itself may end up in a broken state, which crashes our data migration trying to process it.

Changes

  • Added test case with broken formio configuration
  • Added robustness to prevent migration crashes

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages.sh
    • Ran ./bin/compilemessages_js.sh
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

If the formio configuration doesn't make sense to begin with,
there's not much we can do.
Copy link

codecov bot commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.14%. Comparing base (ed4156b) to head (8914f5e).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4252   +/-   ##
=======================================
  Coverage   96.14%   96.14%           
=======================================
  Files         732      732           
  Lines       23496    23501    +5     
  Branches     2751     2752    +1     
=======================================
+ Hits        22591    22596    +5     
  Misses        639      639           
  Partials      266      266           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Viicos
Copy link
Contributor

Viicos commented May 1, 2024

Wondering if the email digest could include this issue

@sergei-maertens
Copy link
Member Author

sergei-maertens commented May 1, 2024

Wondering if the email digest could include this issue

Definitely could! I added #4254

@sergei-maertens sergei-maertens merged commit 01d6df0 into master May 1, 2024
27 checks passed
@sergei-maertens sergei-maertens deleted the issue/4247-migration-crash-bis branch May 1, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken data migration crashes
2 participants