Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decomp: board-h, board-util, gun-util, darkjak-h #1817

Merged
merged 7 commits into from
Sep 1, 2022

Conversation

Hat-Kid
Copy link
Member

@Hat-Kid Hat-Kid commented Aug 30, 2022

  • board-util seems good
  • gun-util has a few problems:
    • I couldn't figure out draw-beam and (method 9 gun-info)
    • Some functions used static lists of pairs which was causing errors, fixed by removing a check in data_decompile.cpp (L225 as an example for such a list)
  • joint.gc will fail the ref tests because root-channel in joint-control was changed to (inline-array joint-control-channel) from uint32 and this change was needed for a lot of stuff in gun-util and board-util as these deal with jetboard and gun animations a lot

decompiler/config/jak2/all-types.gc Show resolved Hide resolved
goal_src/jak2/engine/target/board/board-util.gc Outdated Show resolved Hide resolved
decompiler/config/jak2/all-types.gc Show resolved Hide resolved
goal_src/jak2/engine/target/board/board-util.gc Outdated Show resolved Hide resolved
goal_src/jak2/engine/target/gun/gun-util.gc Outdated Show resolved Hide resolved
@Hat-Kid Hat-Kid changed the title decomp: board-util, gun-util, darkjak-h decomp: board-h, board-util, gun-util, darkjak-h Sep 1, 2022
@water111 water111 merged commit 52bb1c4 into open-goal:master Sep 1, 2022
@Hat-Kid Hat-Kid deleted the h/j2-board-gun-util branch September 1, 2022 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants