Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash in light jak cutscene skip #1839

Merged

Conversation

dallmeyer
Copy link
Contributor

@dallmeyer dallmeyer commented Sep 3, 2022

Fixes #1836

From some testing, it seems the crash happens on the below line, because (-> self tasks current-stage) is not set to something valid (current-stage is accessed within current-status), so then task-status->string crashes when trying to convert the enum to string.

(format #t "sage finalboss exit in status ~S~%" (task-status->string (current-status (-> self tasks))))

@ManDude
Copy link
Member

ManDude commented Sep 3, 2022

just remove that line, it's not necessary

Copy link
Member

@xTVaser xTVaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, seems to work as described -- just removing a log

@xTVaser xTVaser merged commit 6c52905 into open-goal:master Sep 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Cutscene skips] Skipping Light Jak cutscene too quickly crashes
3 participants