scripts: add a script to generate game.gp code, comment out generated code for now
#1966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Agreed that it's too big right now. We are definitely able to put everything needed to build a single DGO file inside the |
water111
approved these changes
Oct 14, 2022
There was a problem hiding this comment.
Thanks!
I agree this is a lot for a single file.
I think we could easily split this up - maybe one file per level or something like that. I haven't tried, but I think you could just put (read-file "path-to-some-other-file.gd") in the game.gp file and it would include that file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generates the
game.gpcode for all DGOs, code added to the project file has been commented out for now.In my opinion, this is way too much in a single file -- it would be nice if this code would live directly inside the
.gdfiles themselves, then everything is nicely organized. But this approach might have issues I'm not aware of.