d/jak2: finish scene-actor, scene-looper, race-part, rigid-body-plat, debug-part, voicebox
#1987
Conversation
xTVaser
force-pushed
the
j2/scene-actor
branch
from
709e08f
to
bd4fea9
Compare
Taskfile.yml
Outdated
| @@ -120,15 +120,15 @@ tasks: | |||
| - '{{.OFFLINETEST_BIN_RELEASE_DIR}}/offline-test --iso_data_path "./iso_data/{{.GAME}}" --game {{.GAME}}' | |||
| offline-tests-fast: | |||
| cmds: | |||
| - '{{.OFFLINETEST_BIN_RELEASE_DIR}}/offline-test --iso_data_path "./iso_data/{{.GAME}}" --game {{.GAME}} --dump_current_output --num_threads 10' | |||
| - '{{.OFFLINETEST_BIN_RELEASE_DIR}}/offline-test --iso_data_path "./iso_data/{{.GAME}}" --game {{.GAME}} --dump_current_output --num_threads 32' | |||
There was a problem hiding this comment.
kinda unrelated, but if we start adding lots of dgos, there's a lot of duplicated work/memory usage because each thread will end up reading all the dgos
There was a problem hiding this comment.
Yeah I somewhat expected that tradeoff, do you think it's something that could be easily improved though? Or perhaps when we have many dgos i can try to partition the work by the dgos themselves so there isn't somewhat-random access within a single thread.
There was a problem hiding this comment.
yeah, I think we can either partition by dgo, or share the ObjectFileDB somehow.
I tried running jak 1 with 16 threads and very quickly ran out of ram
| (-> obj draw art-group data 4) | ||
| ) | ||
|
|
||
| (defmethod init-skeleton! krew-npc ((obj krew-npc)) |
There was a problem hiding this comment.
seems kinda confusing to have both initialize-skeleton and init-skeleton!. Maybe init-skeleton! could be init-art or something like that?
No description provided.