New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
French Subtitles & Game Text #2024
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can one of the admins verify this patch? |
ManDude
requested changes
Nov 16, 2022
ManDude
approved these changes
Nov 16, 2022
0xMisagi
force-pushed
the
french-subtitles
branch
from
November 18, 2022 14:33
9ab8732
to
bc6a5f5
Compare
Ready for offline tests. Let me know if there's any outliers (hopefully there shouldn't be) subtitles are limited to 2 lines max on the default 4x3 resolution as told in the documentation And game_text_fr.gs options menu entries are limited to a single line (manually checked) |
ManDude
approved these changes
Nov 20, 2022
ok to test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cutscenes
Hints
Text