decomp: add explicit failures for common config mistakes related to allowed_objs #2062
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A common thing that can be forgotten about / confusing to new people is that:
allowed_objs
list but it's also in thebanned_objs
list -- the ban still takes precedence with no failureallowed_objs
list but have not allowed the DGO ininputs.jsonc
it will also silently log a failure and continue.This PR turns both situations into an explicit error with advice/a reminder on what to do to fix it.