Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ja zero func #2074

Merged
merged 5 commits into from
Jan 2, 2023
Merged

add ja zero func #2074

merged 5 commits into from
Jan 2, 2023

Conversation

ManDude
Copy link
Member

@ManDude ManDude commented Dec 31, 2022

fixes #2071

@ManDude ManDude mentioned this pull request Dec 31, 2022
Closed
@xTVaser
Copy link
Member

xTVaser commented Dec 31, 2022

This seems to solve my situation, but seems to be a huge regression for existing code.

changes about 20 files like so:
image

in gungame-obs though, it's looks correct
image

@ManDude
Copy link
Member Author

ManDude commented Dec 31, 2022

grrrr

@ManDude ManDude marked this pull request as draft December 31, 2022 18:36
@ManDude ManDude changed the title fix ja identity detect in jak2 add ja zero func Jan 2, 2023
@ManDude ManDude marked this pull request as ready for review January 2, 2023 18:04
@ManDude ManDude added the jak2 label Jan 2, 2023
@ManDude ManDude merged commit 15a8a9c into master Jan 2, 2023
@ManDude ManDude deleted the d/ja-decomp-identity-fix branch January 2, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
jak2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

macros: ja num! identity does not function properly
2 participants
@ManDude @xTVaser