docs - first chunk of work documenting the files I glossed over #2130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xTVaser
commented
Jan 15, 2023
xTVaser
commented
- started documenting the files I glossed over, some are totally done, others are just partially done
- I changed the decompiler to automatically initialize the art-group-info from the json file. This makes updating gsrc, even a single file at a time, have consistent naming
- Though I disabled this functionality for jak 1, as I have no idea if using the ntsc art groups will cause a regression for different versions
- fix indentation for docstrings -- it still doesn't look great, but this is now a formatting concern, rather than the docstring having a bunch of happen-stance leading whitespace.
this is now a formatter concern for reflowing these docstrings
…ession with different versions
xTVaser
force-pushed
the
v/goal-src-cleanup
branch
2 times, most recently
from
1de88f8
to
0caacea
Compare
xTVaser
force-pushed
the
v/goal-src-cleanup
branch
from
0caacea
to
256b08f
Compare
water111
approved these changes
Jan 15, 2023
| @@ -52,6 +52,14 @@ Config read_config_file(const fs::path& path_to_config_file, const std::string& | |||
| config.streamed_audio_file_names = | |||
| inputs_json.at("streamed_audio_file_names").get<std::vector<std::string>>(); | |||
|
|
|||
| if (cfg.contains("art_group_dump_file")) { | |||
There was a problem hiding this comment.
thanks for adding this. I don't remember why I didn't do this in the first place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.