Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speedrun verification text cleanup #2229

Merged
merged 3 commits into from
Feb 21, 2023
Merged

Conversation

dallmeyer
Copy link
Contributor

@dallmeyer dallmeyer commented Feb 20, 2023

We only draw this text to the screen if we're in speedrunner mode anyway, so the #t flag on this line doesn't really add any value imo

(when (and (-> *pc-settings* speedrunner-mode?)
(not (paused?))
(-> *speedrun-info* should-display?))
(with-dma-buffer-add-bucket ((buf (-> (current-frame) global-buf))
(bucket-id debug-no-zbuf))
(draw-string-xy (string-format "OpenGOAL Version: ~S ~%Speedrun mode: ~A ~%Category: ~S ~%Cutscene Skips ~A"
*pc-settings-built-sha*
(-> *pc-settings* speedrunner-mode?)

image

remove unnecessary line in speedrun verification text
@Zedb0T
Copy link
Contributor

Zedb0T commented Feb 20, 2023

It adds value, it shows how it displays to users who watch a speedrun that don't know why it displays for the runner but not for them and also just kind of explains why the menu is there. Without it the text looks extremely out of place imo

@xTVaser
Copy link
Member

xTVaser commented Feb 20, 2023

It adds value, it shows how it displays to users who watch a speedrun that do not know why it displays for the runner but not for them and also just kind of explains why the menu is there. Without it the text looks extremely out of place imo

True, perhaps make it more general then, like

Speedrunner Mode Details:
...
...

Instead of the current symbol display which will always be #t -- which quite frankly I suspect most users won't make the connection that it means true/enabled. Could also cut down speedrun category to just category

@water111 water111 merged commit f388898 into open-goal:master Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants