[jak2] add pal decomp support #2434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
xTVaser
reviewed
Mar 27, 2023
xTVaser
approved these changes
Mar 27, 2023
It might be different when it comes to running the full decompiler, but just for the purposes of extracting assets and building the game, this is enough, likely because it's using the already decompiled goal_src. |
|
add to whitelist |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unsure what hacks or type casts might eventually be needed for the PAL version, but these changes are enough to get things to extract and run the game (though the extract phase requires iso_data to be in a jak2_pal folder, but the build still looks for jak2 in iso_data and decompiler_out).