jak1: clean up all dummy methods
#2457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManDude
requested changes
Apr 5, 2023
water111
approved these changes
Apr 5, 2023
|
|
||
|
|
||
| ; (defmethod find-edge-grabs! target ((obj target) (arg0 collide-cache)) | ||
| ; (format *stdcon* "no edge grabs for you!~%") |
There was a problem hiding this comment.
wow, I guess this has been here for a while...
| ) | ||
| (else | ||
| (new 'static 'rgba :r #xff :g #x80 :a #x40) | ||
| ) |
There was a problem hiding this comment.
cool to see that this works now
| @@ -451,13 +451,13 @@ | |||
| (+! (-> obj sim-time-remaining) | |||
| (* 0.0033333334 (the float (- (-> *display* base-frame-counter) (-> *display* old-base-frame-counter)))) | |||
| ) | |||
| (let ((f30-0 (* DISPLAY_FPS_RATIO 0.016666668)) ;; changed for high fps | |||
| (let ((f30-0 0.016666668) | |||
| ) | ||
| (+! (-> obj to-vu0-waits) arg0) | ||
| (+! (-> obj to-spr-waits) arg1) | ||
| (+! (-> obj from-spr-waits) arg2) |
There was a problem hiding this comment.
wow, this must be ancient if +! wasn't recognized!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up every
dummy-*andTODO-RENAME-*method up with either proper names or by renaming them to[type-name]-method-[method-id]similar to Jak 2'sall-types.Also fixes the bad format string in
collide-cacheand adds the event handler hack to Jak 1.The game boots and runs fine, but I might have missed a PAL patch or other manual patches here and there, please double-check if possible.