New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

subtitles-editor: Allow removing lines and fix some issues #2573

Merged

water111 merged 3 commits into open-goal:master from xTVaser:v/subeditor-remove

Apr 29, 2023

Member

xTVaser commented Apr 26, 2023

Allows for removing a line in the subtitle editor finally, also fixed the following:

The path the editor used didn't include the game name
Loading the subtitle project is too slow to do on startup now (4-5seconds in a debug build), do it on demand now

xTVaser added 3 commits

April 26, 2023 12:25


          subtitles: fix the load path for the subtitle editor

7318c19


          subtitles: support removing lines via the subtitle editor

62310d8


          subtitles: loading the subtitles is too inefficient currently, don't …

d7fc564

…do it on startup anymore

water111 merged commit 8260920 into open-goal:master

8 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment