Show the git commit version in screenshots/videos [Jak 2] #2677
Conversation
|
(Can set display-sha to false in the startup.gc file to disable it for main devs) |
…nner mode one Before this it just didnt turn on but gave zero feedback so it was kind of bad...
2023-05-30.08-29-20.mp4 |
Zedb0T
changed the title
goal_src/jak1/pc/pckernel-h.gc
Outdated
| @@ -374,7 +374,6 @@ | |||
| (define *display-heap-status* #f) | |||
| (define *display-actor-counts* #f) | |||
| (define *display-text-box* #f) | |||
| (define *display-sha* *debug-segment*) | |||
There was a problem hiding this comment.
Why remove this? pckernel-h is loaded for all games.
goal_src/jak1/pc/pckernel-common.gc
Outdated
| @@ -256,7 +258,9 @@ | |||
| `(begin | |||
| (cpad-clear! 0 r1) | |||
| (logxor! ,cheats-var (pc-cheats ,cheat)) | |||
| (cheats-sound-play (logtest? ,cheats-var (pc-cheats ,cheat))) | |||
| (if (-> *pc-settings* speedrunner-mode?) | |||
| (sound-play "caught-eel") | |||
There was a problem hiding this comment.
This sound effect is not in Jak 2! (what's the reason for this change anyway?) Also, fix the indenting please.
There was a problem hiding this comment.
The reasoning for the change is in the commit
Before this it just didnt turn on but gave zero feedback so it was kind of bad...```
Then there is a video that is supplied as well. Do you have any suggestions for a sound that is present in both games?
There was a problem hiding this comment.
Oh, well it wasn't apparent that speedrun mode locked out cheats. Why not just not set the cheat variable instead of this, then?
There was a problem hiding this comment.
What do you mean by that exactly?
There was a problem hiding this comment.
This code still lets the cheat code go through. If you input the cheat for blue eco, you will still get blue eco even with speedrun mode enabled.
This reverts commit 6f6205f.
I dont like this sound as a negative feedback in this case open to suggestions
With issues/screenshots becoming more common its probably time to turn this on for debugging reasons.