formatter: extract formatting into a rules abstraction, add inner
formatting (body vs argument functions)
#2684
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some more foundational work, extracted some of the formatting logic into a rule abstraction so it's easier to add new behaviours / modify current ones. In the long-term I think I won't make a distinction between body/argument function indentation but this was a good exercise either way that cleaned up a good handful of issues.