sdl: Directly use Windows DPI scaling hint, not SDL #2730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
BreakPoints
changed the title
|
Yeah, okay, CI shows it needs to be behind a check |
BreakPoints
force-pushed
the
sdl-scaling2
branch
from
e6d4498
to
378e7fb
Compare
BreakPoints
force-pushed
the
sdl-scaling2
branch
from
53d068e
to
81a0421
Compare
ManDude
approved these changes
Jun 15, 2023
|
ok to test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out I PR'd the wrong change. The SDL hint still required us to handle some changes with SDL_GetWindowSize, etc. Haven't figured out all the changes needed but just using the Windows level hint directly disables OS scaling and SDL scaling.
I tripped up as the SDL scaling still resulted in a sharp image but the pixels were nearest neighbour scaled which lead to an inconsistent blocky image.
Am I fine to just leave an OS specific call here? Linux compile didn't fail for me but maybe it should be hidden behind an OS check?
Fixes #2699
(for real this time)