Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sdl: only call SDL video functions from the gfx thread #2748

Merged
merged 2 commits into from
Jun 19, 2023
Merged

sdl: only call SDL video functions from the gfx thread #2748

merged 2 commits into from
Jun 19, 2023

Conversation

xTVaser
Copy link
Member

@xTVaser xTVaser commented Jun 19, 2023 •
edited

Potentially fixes #2747

ManDude
ManDude approved these changes Jun 19, 2023
View reviewed changes
Copy link
Member

@ManDude ManDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine for me, and makes the EE calls no longer blocking until timeout.

@xTVaser xTVaser merged commit 9590490 into open-goal:master Jun 19, 2023
7 checks passed
@xTVaser xTVaser deleted the v/video-events branch June 19, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManDude ManDude ManDude approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pc_set_display_mode is a blocking call
2 participants
@xTVaser @ManDude