sdl: safer code to resolve intermittent controller crashes related to disconnections #2755
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2752
I had to try really hard to reproduce this (constantly unplugging and plugging in my controller). But this seems to happen for a variety of reasons (i got an DirectX error on the
SDL_GameControllerOpen
call one time), now any issue in the original initialization will result in the controller being skipped and picked up on the next reconnect (hopefully).This may introduce a bug where controllers that legitimately have no name are ignored. To work around this, a call toSDL_GameControllerGetAttached
may be needed to differentiate between a bad device handle and a nameless controller.Nope, controllers in this state return
true
for being "attached and valid":Also I was able to reproduce the LED crash, hopefully checking the handle is sufficient to stave that off, but it might be a bug internally in SDL (because it should just be returning
-1
, not crashing somewhere).