Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: subtitle code cleanup and update new subtitle JSON files to be compatible with Crowdin #2802

Merged
merged 29 commits into from Jul 9, 2023

Conversation

xTVaser
Copy link
Member

@xTVaser xTVaser commented Jul 5, 2023

The main thing that was done here was to slightly modify the new subtitle-v2 JSON schema to be more similar to the existing one so that it can properly be used in Crowdin.

Draft while I double-check the diff myself

Along the way the following was also done (among other things):

  • got rid of as much duplication as was feasible in the serialization and editor code
  • separated the text serialization code from the subtitle code for better organization
  • simplified "base language" in the editor. The new subtitle format has built-in support for defining a base language so the editor doesn't have to be used as a crutch. Also, cutscenes only defined in the base come first in the list now as that is generally the order you'd work from (what you havn't done first)
  • got rid of the GOAL subtitle format code completely
  • switched jak 2 text translations to the JSON format as well
  • found a few mistakes in the jak 1 subtitle metadata files
  • added a couple minor features to the editor
  • consolidate and removed complexity, ie. recently all jak 1 hints were forced to the named type, so I got rid of the two types as there isn't a need anymore.
  • removed subtitle editor groups for jak 1, the only reason they existed was so when the GOAL file was manually written out they were somewhat organized, the editor has a decent filter control, there's no need for them.
  • removed the GOAL -> JSON python script helper, it's been a month or so and no one has come forward with existing translations that they need help with migrating. If they do need it, the script will be in the git history.

I did some reasonably through testing in Jak1/Jak 2 and everything seemed to work. But more testing is always a good idea.

but were in `gk` so this won't work, it has to be refactored to be exceptionless
@xTVaser xTVaser marked this pull request as ready for review July 7, 2023 00:45
@ManDude ManDude merged commit c87db7e into open-goal:master Jul 9, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants