[jak2] Pass 0x01 through format

[water111]

fixes the crash when this message is displayed:

as far as I can tell, it looks right.

[ManDude]

I think our default case in format is wrong. Our version:

        default:
          MsgErr("format: unknown code 0x%02x\n", format_ptr[1]);
          MsgErr("input was %s\n", format_cstring);
          ASSERT(false);
          break;

the ghidra output is:

switchD_00101b6c_caseD_26:
      MsgErr__3ndiPCce(0x12ce48,bVar4);
      goto LAB_0010230c;

LAB_0010230c:
    pbVar15 = pbVar15 + 1;
LAB_00102310:
    bVar4 = *pbVar15;
    bVar11 = *pbVar15;
    pbVar10 = pbVar15;
    puVar3 = local_1b0;

which is closer to:

default:
  MsgErr("format: unknown code 0x%02x\n", format_ptr[1]);
  *output_ptr = *format_ptr;
  output_ptr++;
  format_ptr++;
  break;

We have this branch:

    } else {
      // got normal char, just copy it
      *output_ptr = *format_ptr;
      output_ptr++;
    }

that we should probably just goto to in this case.

[ManDude]

in other words, I think something like this is more accurate to the original code (they either had a goto or a completely different control flow in this function), less annoying, and also functional:

        default:
          MsgErr("format: unknown code 0x%02x\n", format_ptr[1]);
          // MsgErr("input was %s\n", format_cstring);
          goto copy_char_case;
      }
      format_ptr++;
    } else {
copy_char_case:
      // got normal char, just copy it
      *output_ptr = *format_ptr;
      output_ptr++;
    }
    format_ptr++;