[jak3] Decompile gcommon
#3321
Merged
[jak3] Decompile gcommon
#3321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
water111
commented
Jan 20, 2024
| @@ -5386,7 +5571,7 @@ | |||
| :method-count-assert 11 | |||
| :size-assert #xa0 | |||
| :flag-assert #xb000000a0 | |||
| ;; field extra-sound-bank uses ~A with a signed load. | |||
| ;; field extra-sound-bank uses ~A with a signed load. | |||
There was a problem hiding this comment.
I stripped a bunch of trailing whitepsace, which is why the diff looks huge. Nothing past here should actually be changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decompile
gcommon. I adjusted the spacing of docstring comments, and removed some spammy decompiler warning prints.I also added some random notes I had on VU programs from jak1/jak2. They are not polished, but I think it's still worth including since we'll have to go through them again for jak 3.