decomp3: more engine files, get-texture macro, use print method in autogenerated inspect, fix bitfield float print
#3432
Conversation
| str_template += fmt::format("{}{}: #<{} @ #x~X>~%", tabs, f.name(), f.type().print()); | ||
| auto ts = m_ts.lookup_type_no_throw(f.type()); | ||
| if (ts) { | ||
| // try to use print method if the structure implements it |
There was a problem hiding this comment.
This probably needs more testing, but I think you could always use the print method case ({}{}: ~{}P~%). That should work on everything. If you don't define a custom print method, I think it will fall back on a default one.
There was a problem hiding this comment.
This is what I tried at first, but this makes structures without a print method default to structure's print, which would always print #<structure @ #x~X> instead of #<actual-type-name @ #x~X>.
There was a problem hiding this comment.
Oh, good point.
I guess you'd need to check to see if the print method of the type is different from the print method of structure, and only use the actual print method if it is... maybe not worth the effort. Just seeing the vectors in inspect will be a huge improvement.
fma-sphereprim-beam-hcam-startragdolllight-trails-hlight-trailsmenuwaterwater-flowhudhud-classesprogressprogress-drawThe
get-texturemacro replaces calls tolookup-texture-by-idandlookup-texture-by-id-fast. Thedefpartmacro detection was modified to print a pair like(texture-name tpage-name)for the texture field that gets turned into atexture-idconstant. Only used in Jak 3 at the moment, I'll probably go through the other games at a later point.