Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

decomp3 title-obs, credits-h #3476

Merged
merged 5 commits into from
Apr 29, 2024
Merged

decomp3 title-obs, credits-h #3476

merged 5 commits into from
Apr 29, 2024

Conversation

dallmeyer
Copy link
Contributor

No description provided.

@dallmeyer dallmeyer force-pushed the b/j3-decomp-title-obs branch 3 times, most recently from 3a58606 to 90b7b29 Compare April 28, 2024 22:01
@dallmeyer dallmeyer changed the title decomp3 title-obs decomp3 title-obs, credits-h Apr 28, 2024
@dallmeyer dallmeyer marked this pull request as ready for review April 29, 2024 00:05
@dallmeyer dallmeyer requested a review from Hat-Kid April 29, 2024 00:06
Hat-Kid
Hat-Kid requested changes Apr 29, 2024
View reviewed changes
goal_src/jak3/levels/title/title-obs.gc Outdated Show resolved Hide resolved
goal_src/jak3/levels/title/title-obs.gc Outdated Show resolved Hide resolved
decompiler/config/jak3/all-types.gc Show resolved Hide resolved
decompiler/config/jak3/all-types.gc Show resolved Hide resolved
decompiler/config/jak3/all-types.gc Show resolved Hide resolved
decompiler/config/jak3/all-types.gc Show resolved Hide resolved
decompiler/config/jak3/all-types.gc Show resolved Hide resolved
decompiler/config/jak3/all-types.gc Show resolved Hide resolved
decompiler/config/jak3/all-types.gc Show resolved Hide resolved
decompiler/config/jak3/all-types.gc Show resolved Hide resolved
@dallmeyer dallmeyer requested a review from Hat-Kid April 29, 2024 05:54
Hat-Kid
Hat-Kid requested changes Apr 29, 2024
View reviewed changes
Copy link
Member

@Hat-Kid Hat-Kid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two more small nitpicks I missed

goal_src/jak3/levels/title/credits-h.gc Outdated Show resolved Hide resolved
goal_src/jak3/levels/title/title-obs.gc Show resolved Hide resolved
@Hat-Kid Hat-Kid merged commit 0d4e392 into open-goal:master Apr 29, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hat-Kid Hat-Kid Hat-Kid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Main Project Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dallmeyer @Hat-Kid