Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement logging features for decompiler #78

Merged
merged 13 commits into from
Oct 16, 2020

Conversation

doctashay
Copy link
Contributor

This replaces the standard prints in the decompiler with the spdlog equivalent. Work still needs to be done to log the output to a file.

@coveralls
Copy link

coveralls commented Oct 12, 2020

Pull Request Test Coverage Report for Build 309705042

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 81.536%

Totals Coverage Status
Change from base Build 307072741: 0.0%
Covered Lines: 14652
Relevant Lines: 17970

💛 - Coveralls

The console now prints that the disassembly has begun and it may take a few minutes to complete. This will reduce the amount of verbose logging output directly to a console stream.
@doctashay
Copy link
Contributor Author

Decompiler now logs 99% of output to logs/decompiler.log while the decompiler lets the end user know the decompilation is taking process and this may take a few minutes. I see benefit behind adding these arguments as a CMake debug config, so we can test the decompiler further on Windows without the need of entering long arguments within Powershell. We still need to address long build times within issue #79. After spdlog is integrated project-wide, I hope to focus on this issue.

@doctashay doctashay marked this pull request as ready for review October 14, 2020 16:46
Ignore decompiler output for now
Copy link
Collaborator

@water111 water111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! There are a few that need tweaks, but other than that it's perfect!

decompiler/ObjectFile/ObjectFileDB.cpp Outdated Show resolved Hide resolved
decompiler/ObjectFile/ObjectFileDB.cpp Outdated Show resolved Hide resolved
decompiler/main.cpp Outdated Show resolved Hide resolved
decompiler/ObjectFile/ObjectFileDB.cpp Outdated Show resolved Hide resolved
decompiler/ObjectFile/ObjectFileDB.cpp Outdated Show resolved Hide resolved
decompiler/ObjectFile/ObjectFileDB.cpp Outdated Show resolved Hide resolved
@water111 water111 merged commit 9410e01 into open-goal:master Oct 16, 2020
@doctashay doctashay deleted the decompiler-logging branch January 18, 2021 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants