Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'edgeNodeFiles.sh -f <dir>' does not work #2187

Closed
bmpotter opened this issue Nov 3, 2020 · 3 comments
Closed

'edgeNodeFiles.sh -f <dir>' does not work #2187

bmpotter opened this issue Nov 3, 2020 · 3 comments
Assignees
Labels

Comments

@bmpotter
Copy link
Member

bmpotter commented Nov 3, 2020

It puts the gathered files in the current directory instead of the one specified.

The fix is that all 3 lines:

if [[ -n $DIR ]]; then pushd; fi

need to be changed to this:

if [[ -n $DIR ]]; then pushd $DIR; fi

Until this is fixed a work around is to run it like this:

(cd <dir> && edgeNodeFiles.sh ... )
@bmpotter bmpotter self-assigned this Nov 3, 2020
@xauthulei
Copy link
Contributor

@bmpotter , Is that OK to let me fix this ? Thanks

@bmpotter
Copy link
Member Author

@xauthulei Yes, thank you!

@bencourliss
Copy link
Member

Tested the following use-cases:

  • Omitting the -f flag outputs the content in current directory
  • Specifying the -f flag with a directory that doesn't exist results in error and specific message
  • Specifying the -f flag with a directory that does exist results in content being placed in the specified directory
  • Rerunning the edgeNodeFiles.sh script again without cleaning up the previous run is still successful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants