Fix the issue2187 #2216
Closed
Fix the issue2187 #2216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: leileihu <leileihu@cn.ibm.com>
bmpotter
requested changes
Jan 10, 2021
| @@ -511,7 +511,7 @@ all_main() { | |||
|
|
|||
| cloudLogin | |||
|
|
|||
| if [[ -n $DIR ]]; then pushd; fi # if they want the files somewhere else, make that our current dir | |||
| if [[ -n $DIR && -d $DIR ]]; then pushd $DIR; fi # if they want the files somewhere else, make that our current dir | |||
There was a problem hiding this comment.
This isn't quite right. The effect of && -d $DIR is that if the user specified -f <dir> flag (which sets DIR) but the <dir> specified didn't exist or was a file, it would silently not use it (confusing the user).
You have 2 choices:
- Just remove
&& -d $DIRfrom all of the lines you added it to. This will causepushdto display an error msg if the directory is not valid. - Or do number 1 and add a check in
checkPrereqsAndInputthat the directory specified is valid, and display an error msg and return exit code 1 if not.
The fact that you didn't catch this problem makes me think you didn't test your code thoroughly enough before submitting the PR. Please test both the good path and the error cases. Thx.
There was a problem hiding this comment.
Yea, it should be reasonable. Thanks.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am try to address the issue 2187, @bmpotter , Could you review this, thanks