Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue3621 table #3622

Merged
merged 7 commits into from
Jan 31, 2023
Merged

Issue3621 table #3622

merged 7 commits into from
Jan 31, 2023

Conversation

johnwalicki
Copy link
Member

Pull Request Template

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #3621

  • The table captions need to be corrected.
  • Several pages have grammar issues
  • Several pages have spelling issues
  • Change the order in the Navigation structure
  • Change a link to the mgmt hub docs

Type of change

  • This change requires a documentation update

...

Checklist:

  • I have checked my code and corrected any misspellings
  • I have tagged the reviewers in a comment below incase my pull request is ready for a review
  • I have signed the commit message to agree to Developer Certificate of Origin (DCO) (to certify that you wrote or otherwise have the right to submit your contribution to the project.) by adding "--signoff" to my git commit command.

Signed-off-by: John Walicki <johnwalicki@gmail.com>
Signed-off-by: John Walicki <johnwalicki@gmail.com>
Signed-off-by: John Walicki <johnwalicki@gmail.com>
Signed-off-by: John Walicki <johnwalicki@gmail.com>
Signed-off-by: John Walicki <johnwalicki@gmail.com>
Signed-off-by: John Walicki <johnwalicki@gmail.com>
Signed-off-by: John Walicki <johnwalicki@gmail.com>
@johnwalicki
Copy link
Member Author

This is a continuation of #3601 and #3615

Copy link
Member

@joewxboy joewxboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right. Let's see how it renders in production.

@johnwalicki johnwalicki merged commit 414b573 into master Jan 31, 2023
@johnwalicki johnwalicki deleted the issue3621-table branch January 31, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation: Fix API tables
2 participants