Issue 637: Added CORS Support #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - Issue 637 - Added CORS support. Can be configurated via the Exchange's config.json file. - Changed Java package path to the prefix org.openhorizon. - Moved source handling routing to new sub-package org.openhorizon.route.. - AdminRoutes and AgbotRoutes have been further sub-divided based on rest resource. - Deprecated custom methods for handling Akka configuration parameters in favor of framework defaults. - Backwards compatibility is still maintained. Signed-off-by: Nathan Phelps <naphelps@us.ibm.com>
Signed-off-by: Nathan Phelps <naphelps@us.ibm.com>
# Conflicts: # CHANGELOG.md # docs/README.md # docs/openapi-3-developer.json # docs/openapi-3-user.json # src/main/resources/version.txt # src/main/scala/com/horizon/exchangeapi/tables/Patterns.scala # src/main/scala/org/openhorizon/exchangeapi/table/Nodes.scala
|
The default shipped config is to allow all (CORS checks/rejections are opt-in) for backwards compatibility. Config can be changed via config.json. See README for details. |
Thanks. I'll defer to @playground for compatibility verification/validation. |
|
Thanks @naphelps for the info, that works for me. Is this available yet for me to test? |
|
Can be tested by pulling this PR and building the Exchange. You could also pull my branch from my repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References: #637
Changes: