Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #432 - fix lint warnings #433

Merged
merged 1 commit into from Feb 20, 2023
Merged

Issue #432 - fix lint warnings #433

merged 1 commit into from Feb 20, 2023

Conversation

johnwalicki
Copy link
Member

Pull Request Template

Fixes #432

  • fix Lint warnings

Type of change

  • This change requires a documentation update

Checklist:

  • I have tagged the reviewers in a comment below incase my pull request is ready for a review
  • I have signed the commit message to agree to Developer Certificate of Origin (DCO) (to certify that you wrote or otherwise have the right to submit your contribution to the project.) by adding "--signoff" to my git commit command.

Signed-off-by: John Walicki <johnwalicki@gmail.com>
Copy link
Member

@joewxboy joewxboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this directive do anything?

{: codeblock}

I used to use it at the end of a code block because the "copy to clipboard" function that I used required it. I believe the new Jekyll template no longer requires it. Is it being used downstream or for a purpose of which I am unaware?

@johnwalicki
Copy link
Member Author

@joewxboy I don't know the providence of the {: codeblock} directive. I think Rene uses it downstream?

@johnwalicki johnwalicki merged commit 7daee4c into master Feb 20, 2023
@johnwalicki johnwalicki deleted the issue432-lintwarnings branch February 20, 2023 02:26
@johnwalicki
Copy link
Member Author

@joewxboy - Yes, I confirmed. The downstream documentation requires the {: codeblock} directive to show the Copy to Clipboard icon. I found a downstream page where the directive is missing from a code block - and that section does not have a Copy to Clipboard icon.

@joewxboy
Copy link
Member

Thanks. I'll add to Best Practices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation📄: Fix lint warnings
2 participants